# Code contribution - Concatenate filter **URL:** \ **Category:** Elasticsearch\ **Created:** [July 4, 2011, 9:54am UTC](https://discuss.elastic.co/t/code-contribution-concatenate-filter/4768 "2011-07-04T09:54:21Z")\ **Posts on this page:** 9\ **Page:** 1
**Author:** ![Stephane\_Bastian](https://avatars.discourse-cdn.com/v4/letter/s/35a633/32.png) [@Stephane\_Bastian](https://discuss.elastic.co/u/Stephane_Bastian)\ **Post date:** [July 4, 2011, 9:54am UTC](https://discuss.elastic.co/t/code-contribution-concatenate-filter/4768/1 "2011-07-04T09:54:21Z")
Hi, I recently had a need for a filter that concatenates tokens. There is no such filter in ES out-of-the-box, so I developed it. This filter might be useful to others and I'm wondering if there a 'contrib' package in ES where I could commit the code? Stephane Bastian ---
**Author:** ![kimchy](https://sea2.discourse-cdn.com/elastic/user_avatar/discuss.elastic.co/kimchy/32/44952_2.png) [@kimchy](https://discuss.elastic.co/u/kimchy)\ **Post date:** [July 4, 2011, 11:26am UTC](https://discuss.elastic.co/t/code-contribution-concatenate-filter/4768/2 "2011-07-04T11:26:42Z")
Hi Stephane, You can send a pull request, or maybe point me to a place where I can look at the code. If its a pure Lucene filter, maybe it makes sense to contribute it to Lucene, and then use it in elasticsearch? -shay.banon On Monday, July 4, 2011 at 12:54 PM, stephane wrote: > Hi, > > I recently had a need for a filter that concatenates tokens. There is no > such filter in ES out-of-the-box, so I developed it. > This filter might be useful to others and I'm wondering if there a > 'contrib' package in ES where I could commit the code? > > Stephane Bastian ---
**Author:** ![otisg](https://sea2.discourse-cdn.com/elastic/user_avatar/discuss.elastic.co/otisg/32/492_2.png) [@otisg](https://discuss.elastic.co/u/otisg)\ **Post date:** [July 5, 2011, 12:22am UTC](https://discuss.elastic.co/t/code-contribution-concatenate-filter/4768/3 "2011-07-05T00:22:38Z")
Hi, Is this ES-specific? Or Lucene-level code? If the latter, wouldn't it make more sense to contribute it to Lucene instead? ES could still use it. ## Otis Sematext is hiring search people! [Jobs](http://sematext.com/about/jobs.html) On Jul 4, 7:26 am, Shay Banon [shay.ba...@elasticsearch.com](mailto:shay.ba...@elasticsearch.com) wrote: > Hi Stephane, > > You can send a pull request, or maybe point me to a place where I can look at the code. If its a pure Lucene filter, maybe it makes sense to contribute it to Lucene, and then use it in elasticsearch? > > -shay.banon > > On Monday, July 4, 2011 at 12:54 PM, stephane wrote: > > > Hi, > > > I recently had a need for a filter that concatenates tokens. There is no > > such filter in ES out-of-the-box, so I developed it. > > This filter might be useful to others and I'm wondering if there a > > 'contrib' package in ES where I could commit the code? > > > Stephane Bastian ---
**Author:** ![Stephane\_Bastian](https://avatars.discourse-cdn.com/v4/letter/s/35a633/32.png) [@Stephane\_Bastian](https://discuss.elastic.co/u/Stephane_Bastian)\ **Post date:** [July 5, 2011, 8:03am UTC](https://discuss.elastic.co/t/code-contribution-concatenate-filter/4768/4 "2011-07-05T08:03:21Z")
Hi all, The filter is a very simple lucene filter. Then there is the factory class to make it work in ES. You are both right, it makes sens to contribute the filter to Lucene and the factory to ES. Stephane On Mon, 2011-07-04 at 17:22 -0700, Otis wrote: > Hi, > > Is this ES-specific? Or Lucene-level code? > If the latter, wouldn't it make more sense to contribute it to Lucene > instead? ES could still use it. > > ## Otis > > Sematext is hiring search people! [Jobs - Sematext](http://sematext.com/about/jobs.html) > > On Jul 4, 7:26 am, Shay Banon [shay.ba...@elasticsearch.com](mailto:shay.ba...@elasticsearch.com) wrote: > > > Hi Stephane, > > > > You can send a pull request, or maybe point me to a place where I can look at the code. If its a pure Lucene filter, maybe it makes sense to contribute it to Lucene, and then use it in elasticsearch? > > > > -shay.banon > > > > On Monday, July 4, 2011 at 12:54 PM, stephane wrote: > > > > > Hi, > > > > > I recently had a need for a filter that concatenates tokens. There is no > > > such filter in ES out-of-the-box, so I developed it. > > > This filter might be useful to others and I'm wondering if there a > > > 'contrib' package in ES where I could commit the code? > > > > > Stephane Bastian ---
**Author:** ![kimchy](https://sea2.discourse-cdn.com/elastic/user_avatar/discuss.elastic.co/kimchy/32/44952_2.png) [@kimchy](https://discuss.elastic.co/u/kimchy)\ **Post date:** [July 5, 2011, 11:02am UTC](https://discuss.elastic.co/t/code-contribution-concatenate-filter/4768/5 "2011-07-05T11:02:52Z")
Maybe you can point at the code for the filter and the factory (send a pull request)? I can review it if you want, and we can work on getting it submitted as a patch to Lucene (the filter itself). On Tuesday, July 5, 2011 at 11:03 AM, stephane wrote: > Hi all, > > The filter is a very simple lucene filter. Then there is the factory > class to make it work in ES. > You are both right, it makes sens to contribute the filter to Lucene and > the factory to ES. > > Stephane > > On Mon, 2011-07-04 at 17:22 -0700, Otis wrote: > > > Hi, > > > > Is this ES-specific? Or Lucene-level code? > > If the latter, wouldn't it make more sense to contribute it to Lucene > > instead? ES could still use it. > > > > ## Otis > > > > Sematext is hiring search people! [Jobs - Sematext](http://sematext.com/about/jobs.html) > > > > On Jul 4, 7:26 am, Shay Banon \<[shay.ba...@elasticsearch.com](mailto:shay.ba...@elasticsearch.com) ([http://elasticsearch.com](http://elasticsearch.com))\> wrote: > > > > > Hi Stephane, > > > > > > You can send a pull request, or maybe point me to a place where I can look at the code. If its a pure Lucene filter, maybe it makes sense to contribute it to Lucene, and then use it in elasticsearch? > > > > > > -shay.banon > > > > > > On Monday, July 4, 2011 at 12:54 PM, stephane wrote: > > > > > > > Hi, > > > > > > > I recently had a need for a filter that concatenates tokens. There is no > > > > such filter in ES out-of-the-box, so I developed it. > > > > This filter might be useful to others and I'm wondering if there a > > > > 'contrib' package in ES where I could commit the code? > > > > > > > Stephane Bastian ---
**Author:** ![cole](https://avatars.discourse-cdn.com/v4/letter/c/53a042/32.png) [@cole](https://discuss.elastic.co/u/cole)\ **Post date:** [February 1, 2012, 8:31pm UTC](https://discuss.elastic.co/t/code-contribution-concatenate-filter/4768/6 "2012-02-01T20:31:54Z")
Hi Stephane and Shay, Was there any progress in adding the concatenation filter to Lucene (and ES) last summer? I can't find any evidence of built-in support for this type of filter. Thanks, Cole ---
**Author:** ![kimchy](https://sea2.discourse-cdn.com/elastic/user_avatar/discuss.elastic.co/kimchy/32/44952_2.png) [@kimchy](https://discuss.elastic.co/u/kimchy)\ **Post date:** [February 5, 2012, 11:53am UTC](https://discuss.elastic.co/t/code-contribution-concatenate-filter/4768/7 "2012-02-05T11:53:51Z")
Do you have a reference to it? I don't remember it... On Wednesday, February 1, 2012 at 10:31 PM, cole wrote: > Hi Stephane and Shay, > > Was there any progress in adding the concatenation filter to Lucene (and ES) > last summer? I can't find any evidence of built-in support for this type of > filter. > > Thanks, > Cole > > -- > View this message in context: [http://elasticsearch-users.115913.n3.nabble.com/Code-contribution-Concatenate-filter-tp3137058p3707818.html](http://elasticsearch-users.115913.n3.nabble.com/Code-contribution-Concatenate-filter-tp3137058p3707818.html) > Sent from the Elasticsearch Users mailing list archive at [Nabble.com](http://Nabble.com) ([http://Nabble.com](http://Nabble.com)). ---
**Author:** ![cole](https://avatars.discourse-cdn.com/v4/letter/c/53a042/32.png) [@cole](https://discuss.elastic.co/u/cole)\ **Post date:** [February 6, 2012, 10:54pm UTC](https://discuss.elastic.co/t/code-contribution-concatenate-filter/4768/8 "2012-02-06T22:54:31Z")
Hi Shay, I had some mailing list confusion and ended up starting a new thread for my question. Stephane answered it here: [http://elasticsearch-users.115913.n3.nabble.com/Is-there-a-concatenation-filter-td3711094.html](http://elasticsearch-users.115913.n3.nabble.com/Is-there-a-concatenation-filter-td3711094.html) Thanks, cole ---
**Author:** ![system](https://us1.discourse-cdn.com/elastic/original/3X/1/a/1ac57faf039f6b580b3f104ef42a2a89e41014de.png) [@system](https://discuss.elastic.co/u/system)\ **Post date:** [July 6, 2017, 3:40am UTC](https://discuss.elastic.co/t/code-contribution-concatenate-filter/4768/9 "2017-07-06T03:40:27Z")