# Input wanted on source code issues,

**URL:** <https://discuss.elastic.co/t/input-wanted-on-source-code-issues/83624>\
**Category:** Elasticsearch\
**Created:** [April 25, 2017, 11:33pm UTC](https://discuss.elastic.co/t/input-wanted-on-source-code-issues/83624 "2017-04-25T23:33:30Z")\
**Posts on this page:** 2\
**Page:** 1

<div class="post-metadata">

**Author:** ![KoenDG](https://avatars.discourse-cdn.com/v4/letter/k/779978/32.png) [@KoenDG](https://discuss.elastic.co/u/KoenDG)\
**Post date:** [April 25, 2017, 11:33pm UTC](https://discuss.elastic.co/t/input-wanted-on-source-code-issues/83624/1 "2017-04-25T23:33:30Z")

</div>

I've been going over the source code and noticed a few things that are a bit of headscratcher. Meaning I think they're bugs or at least an oversight.

As of right now, I have 2 that I found:

1. [https://github.com/elastic/elasticsearch/blob/master/core/src/main/java/org/elasticsearch/index/mapper/DocumentParser.java#L458](https://github.com/elastic/elasticsearch/blob/master/core/src/main/java/org/elasticsearch/index/mapper/DocumentParser.java#L458)

It was confirmed on GitHub that the return of this is never used and the method should be re-written

1. [https://github.com/elastic/elasticsearch/blob/master/modules/aggs-matrix-stats/src/main/java/org/elasticsearch/search/aggregations/support/MultiValuesSourceParser.java#L78](https://github.com/elastic/elasticsearch/blob/master/modules/aggs-matrix-stats/src/main/java/org/elasticsearch/search/aggregations/support/MultiValuesSourceParser.java#L78)

On line 83, a variable `valueType` is made. It is never used in the while-loop below it, only to eventually hit line 150, where it is checked for null and will always be null.

What should happen in this case?

---

<div class="post-metadata">

**Author:** ![system](https://us1.discourse-cdn.com/elastic/original/3X/1/a/1ac57faf039f6b580b3f104ef42a2a89e41014de.png) [@system](https://discuss.elastic.co/u/system)\
**Post date:** [May 23, 2017, 11:36pm UTC](https://discuss.elastic.co/t/input-wanted-on-source-code-issues/83624/2 "2017-05-23T23:36:21Z")

</div>

Closed on May 23, 2017, 11:36pm UTC

This topic was automatically closed 28 days after the last reply. New replies are no longer allowed.