LittleEndian vs BigEndian in go agent

[euskadi31 (Axel Etcheverry)]

Hi,

is not it a problem to use LittleEndian and BigEndian on SpanID?

see:

• https://github.com/elastic/apm-agent-go/blob/be583fe97a9551c2e19de7902b15086308b13cee/transaction.go#L69

• https://github.com/elastic/apm-agent-go/blob/master/span.go#L111

• https://github.com/elastic/apm-agent-go/blob/e510527b3a3b5be41fdea807e4b776931bd76689/sampler.go#L64

[axw (Andrew Wilkins)]

Hi @euskadi31, welcome to the forum

Keen eyes! The difference in endianness is not a problem.

In the first two cases we're just generating some random bytes, and it's been a while, but I think this was just the most efficient way to do it. In the sampler we're just interested in knowing whether the span ID, when converted to a number, is less than a predetermined value. They don't need to be consistent with each other.

[euskadi31 (Axel Etcheverry)]

ok, Thank you for your explanation