Access to AbstractAggregationBuilder.name


(Phil Wills-2) #1

Hello,

In the Java API AbstractAggregationBuilder's name property is protected. Is
there a particular reason it can't be public, or have an accessor added, or
is this something you'd consider a PR for?

Not having access is making things more complicated than I'd like.

Thanks,

Phil

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elasticsearch/63c1ae3f-ff37-4f47-9147-037d19ff9eec%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


(Adrien Grand) #2

Hi Phil,

We would indeed consider a PR for that change if it makes things easier to
you. Feel free to ping me when you open it so that I don't miss it.

On Wed, Aug 13, 2014 at 3:55 PM, Phil Wills otherphil@gmail.com wrote:

Hello,

In the Java API AbstractAggregationBuilder's name property is protected.
Is there a particular reason it can't be public, or have an accessor added,
or is this something you'd consider a PR for?

Not having access is making things more complicated than I'd like.

Thanks,

Phil

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/elasticsearch/63c1ae3f-ff37-4f47-9147-037d19ff9eec%40googlegroups.com
https://groups.google.com/d/msgid/elasticsearch/63c1ae3f-ff37-4f47-9147-037d19ff9eec%40googlegroups.com?utm_medium=email&utm_source=footer
.
For more options, visit https://groups.google.com/d/optout.

--
Adrien Grand

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elasticsearch/CAL6Z4j6kGnOjSHYMQD%3DtEsJvaMuGps3qBHyaTHGQk%3DemKbXGvA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


(system) #3