Contributing a JMS River Plugin

How would I go about submitting the code for a JMS river plugin I created?
It didn't seem like I should go through the whole fork, clone, pull request
thing, as I am not actually modifying the elasticsearch code.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

You can add your project to the list of contributed third-party code. Fork
the documentation repo and add it to the client page.

http://www.elasticsearch.org/guide/clients/
https://github.com/elasticsearch/elasticsearch.github.com/blob/master/guide/clients/index.textile

--
Ivan

On Mon, Apr 29, 2013 at 6:44 AM, Aall Spemmer sssml2011@gmail.com wrote:

How would I go about submitting the code for a JMS river plugin I
created? It didn't seem like I should go through the whole fork, clone,
pull request thing, as I am not actually modifying the elasticsearch code.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Thanks. There don't appear to be any other river plugins listed here.
Wouldn't http://www.elasticsearch.org/guide/reference/river/ be better a
place?

On Monday, April 29, 2013 10:27:47 AM UTC-4, Ivan Brusic wrote:

You can add your project to the list of contributed third-party code. Fork
the documentation repo and add it to the client page.

http://www.elasticsearch.org/guide/clients/

https://github.com/elasticsearch/elasticsearch.github.com/blob/master/guide/clients/index.textile

--
Ivan

On Mon, Apr 29, 2013 at 6:44 AM, Aall Spemmer <sssm...@gmail.com<javascript:>

wrote:

How would I go about submitting the code for a JMS river plugin I
created? It didn't seem like I should go through the whole fork, clone,
pull request thing, as I am not actually modifying the elasticsearch code.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearc...@googlegroups.com <javascript:>.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Hey,

the rivers are listed under plugins at the moment
http://www.elasticsearch.org/guide/reference/modules/plugins/

if you feel, your river is ready for production, drop us a note and are
happy to put it on the homepage.

--Alex

On Mon, Apr 29, 2013 at 4:43 PM, Aall Spemmer sssml2011@gmail.com wrote:

Thanks. There don't appear to be any other river plugins listed here.
Wouldn't http://www.elasticsearch.org/guide/reference/river/ be better a
place?

On Monday, April 29, 2013 10:27:47 AM UTC-4, Ivan Brusic wrote:

You can add your project to the list of contributed third-party code.
Fork the documentation repo and add it to the client page.

http://www.elasticsearch.org/**guide/clients/http://www.elasticsearch.org/guide/clients/
https://github.com/elasticsearch/elasticsearch.
github.com/blob/master/guide/**clients/index.textilehttps://github.com/elasticsearch/elasticsearch.github.com/blob/master/guide/clients/index.textile

--
Ivan

On Mon, Apr 29, 2013 at 6:44 AM, Aall Spemmer sssm...@gmail.com wrote:

How would I go about submitting the code for a JMS river plugin I
created? It didn't seem like I should go through the whole fork, clone,
pull request thing, as I am not actually modifying the elasticsearch code.

--
You received this message because you are subscribed to the Google
Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to elasticsearc...@**googlegroups.com.

For more options, visit https://groups.google.com/**groups/opt_outhttps://groups.google.com/groups/opt_out
.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Thanks for correcting my mistake Alexander. Wrong page. It does show the
need to re-organize the docs though. :slight_smile: Thinking in terms of "modules",
which is primarily a code-level concept, can be confusing.

--
Ivan

On Mon, Apr 29, 2013 at 7:45 AM, Alexander Reelsen alr@spinscale.de wrote:

Hey,

the rivers are listed under plugins at the moment
http://www.elasticsearch.org/guide/reference/modules/plugins/

if you feel, your river is ready for production, drop us a note and are
happy to put it on the homepage.

--Alex

On Mon, Apr 29, 2013 at 4:43 PM, Aall Spemmer sssml2011@gmail.com wrote:

Thanks. There don't appear to be any other river plugins listed here.
Wouldn't http://www.elasticsearch.org/guide/reference/river/ be better a
place?

On Monday, April 29, 2013 10:27:47 AM UTC-4, Ivan Brusic wrote:

You can add your project to the list of contributed third-party code.
Fork the documentation repo and add it to the client page.

http://www.elasticsearch.org/**guide/clients/http://www.elasticsearch.org/guide/clients/
https://github.com/elasticsearch/elasticsearch.
github.com/blob/master/guide/**clients/index.textilehttps://github.com/elasticsearch/elasticsearch.github.com/blob/master/guide/clients/index.textile

--
Ivan

On Mon, Apr 29, 2013 at 6:44 AM, Aall Spemmer sssm...@gmail.com wrote:

How would I go about submitting the code for a JMS river plugin I
created? It didn't seem like I should go through the whole fork, clone,
pull request thing, as I am not actually modifying the elasticsearch code.

--
You received this message because you are subscribed to the Google
Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to elasticsearc...@**googlegroups.com.

For more options, visit https://groups.google.com/**groups/opt_outhttps://groups.google.com/groups/opt_out
.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

My JMS river is ready for production. Please add a link to
https://github.com/qotho/elasticsearch-river-jms on the elasticsearch home
page. Thanks.

I have also submitted a pull request to add a link to the
guide/reference/modules/plugins section of the documentation.

On Monday, April 29, 2013 10:45:30 AM UTC-4, Alexander Reelsen wrote:

Hey,

the rivers are listed under plugins at the moment
http://www.elasticsearch.org/guide/reference/modules/plugins/

if you feel, your river is ready for production, drop us a note and are
happy to put it on the homepage.

--Alex

On Mon, Apr 29, 2013 at 4:43 PM, Aall Spemmer <sssm...@gmail.com<javascript:>

wrote:

Thanks. There don't appear to be any other river plugins listed here.
Wouldn't http://www.elasticsearch.org/guide/reference/river/ be better a
place?

On Monday, April 29, 2013 10:27:47 AM UTC-4, Ivan Brusic wrote:

You can add your project to the list of contributed third-party code.
Fork the documentation repo and add it to the client page.

http://www.elasticsearch.org/**guide/clients/http://www.elasticsearch.org/guide/clients/
https://github.com/elasticsearch/elasticsearch.
github.com/blob/master/guide/**clients/index.textilehttps://github.com/elasticsearch/elasticsearch.github.com/blob/master/guide/clients/index.textile

--
Ivan

On Mon, Apr 29, 2013 at 6:44 AM, Aall Spemmer sssm...@gmail.com wrote:

How would I go about submitting the code for a JMS river plugin I
created? It didn't seem like I should go through the whole fork, clone,
pull request thing, as I am not actually modifying the elasticsearch code.

--
You received this message because you are subscribed to the Google
Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to elasticsearc...@**googlegroups.com.

For more options, visit https://groups.google.com/**groups/opt_outhttps://groups.google.com/groups/opt_out
.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearc...@googlegroups.com <javascript:>.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

My JMS river is ready for production. Please add a link to
https://github.com/qotho/elasticsearch-river-jms on the elasticsearch home
page. Thanks.

I have also submitted a pull request to add a link to the
guide/reference/modules/plugins section of the documentation.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

My JMS river is ready for production.

You may want to change this on your README then: "NOTE: DOESN'T WORK YET"

:wink:

On Thursday, May 2, 2013 7:18:05 PM UTC-4, Aall Spemmer wrote:

My JMS river is ready for production. Please add a link to
https://github.com/qotho/elasticsearch-river-jms on the elasticsearch
home page. Thanks.

I have also submitted a pull request to add a link to the
guide/reference/modules/plugins section of the documentation.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Sorry, I thought it was clear that refers to installing the plugin using
the elasticsearch plugin script. I haven't gotten this to work yet, other
than running Maven to create the ZIP and using the "file://" URL method to
install the ZIP locally.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Non-explicit (no url scheme) remote plugin installs will not work unless it
is an official ElasticSearch plugin or a Maven.org/Sonatype project. You
can upload the jar somewhere and use a full URL path for the install. For
example, Jorg's JDBC river plugin: plugin -url http://bit.ly/Yp2Drj -install
river-jdbc

--
Ivan

On Fri, May 3, 2013 at 3:19 AM, Aall Spemmer sssml2011@gmail.com wrote:

Sorry, I thought it was clear that refers to installing the plugin using
the elasticsearch plugin script. I haven't gotten this to work yet, other
than running Maven to create the ZIP and using the "file://" URL method to
install the ZIP locally.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Thanks. I figured it out after looking through the PluginManager code. I
just added a releases folder to the project on GitHub and built the zip in
there. That seems to work.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

If you add any binary to git, all its versions (you will be updating your
project, right?) will be download when you clone the repository in the
history. It is better to separate the binaries from the source

Jorg introduced me to a site called https://bintray.com/

--
Ivan

On Fri, May 3, 2013 at 9:02 AM, Aall Spemmer sssml2011@gmail.com wrote:

Thanks. I figured it out after looking through the PluginManager code. I
just added a releases folder to the project on GitHub and built the zip in
there. That seems to work.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

As Ivan said, a big -1 to have binaries within source code.
Send it to sonatype using mvn release process. It's a bit tricky to create your first sonatype repo but after, it works like a charm.

More, maven users will be able to embed your plugin in their java app (using jar, not ZIP).

My 2 cents

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 4 mai 2013 à 00:41, Ivan Brusic ivan@brusic.com a écrit :

If you add any binary to git, all its versions (you will be updating your project, right?) will be download when you clone the repository in the history. It is better to separate the binaries from the source

Jorg introduced me to a site called https://bintray.com/

--
Ivan

On Fri, May 3, 2013 at 9:02 AM, Aall Spemmer sssml2011@gmail.com wrote:

Thanks. I figured it out after looking through the PluginManager code. I just added a releases folder to the project on GitHub and built the zip in there. That seems to work.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

I wrote a blog post about how easy it is to deploy ES plugin binaries to
Bintray, because Github terminated the download service.

http://jprante.github.io/2013/01/18/Bintray-for-Elasticsearch-plugins.html

David, will plugin code reuse be supported in the future? I wonder how
this can be accomplished - imagine you want only reuse plugin code, but
not the plugin jar with the es-plugin.properties mechanism.

Of course, Bintray is also usable as a Maven repo, and I would love to
see plugin developers being able to set up dependencies to reuse code
from different plugins from different repos.

Jörg

Am 04.05.13 01:59, schrieb David Pilato:

As Ivan said, a big -1 to have binaries within source code.
Send it to sonatype using mvn release process. It's a bit tricky to
create your first sonatype repo but after, it works like a charm.

More, maven users will be able to embed your plugin in their java app
(using jar, not ZIP).

My 2 cents

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 4 mai 2013 à 00:41, Ivan Brusic <ivan@brusic.com
mailto:ivan@brusic.com> a écrit :

If you add any binary to git, all its versions (you will be updating
your project, right?) will be download when you clone
the repository in the history. It is better to separate the binaries
from the source

Jorg introduced me to a site called https://bintray.com/

--
Ivan

On Fri, May 3, 2013 at 9:02 AM, Aall Spemmer <sssml2011@gmail.com
mailto:sssml2011@gmail.com> wrote:

Thanks.  I figured it out after looking through the PluginManager
code.  I just added a releases folder to the project on GitHub and
built the zip in there. That seems to work.

-- 
You received this message because you are subscribed to the Google
Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to elasticsearch+unsubscribe@googlegroups.com
<mailto:elasticsearch%2Bunsubscribe@googlegroups.com>.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google
Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to elasticsearch+unsubscribe@googlegroups.com
mailto:elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google
Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

David, will plugin code reuse be supported in the future?
IMHO, the easiest way to do it is to have 2 maven modules (+ pom parent project):

  • core plugin
  • es plugin
    Es plugin only contains es-plugin.properties and a dependency to core plugin.

About oss.sonatype, the cool thing is that your oss repo is synch'ed to maven central. No need to define specific repos.

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 4 mai 2013 à 02:44, Jörg Prante joergprante@gmail.com a écrit :

I wrote a blog post about how easy it is to deploy ES plugin binaries to Bintray, because Github terminated the download service.

http://jprante.github.io/2013/01/18/Bintray-for-Elasticsearch-plugins.html

David, will plugin code reuse be supported in the future? I wonder how this can be accomplished - imagine you want only reuse plugin code, but not the plugin jar with the es-plugin.properties mechanism.

Of course, Bintray is also usable as a Maven repo, and I would love to see plugin developers being able to set up dependencies to reuse code from different plugins from different repos.

Jörg

Am 04.05.13 01:59, schrieb David Pilato:

As Ivan said, a big -1 to have binaries within source code.
Send it to sonatype using mvn release process. It's a bit tricky to create your first sonatype repo but after, it works like a charm.

More, maven users will be able to embed your plugin in their java app (using jar, not ZIP).

My 2 cents

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 4 mai 2013 à 00:41, Ivan Brusic <ivan@brusic.com mailto:ivan@brusic.com> a écrit :

If you add any binary to git, all its versions (you will be updating your project, right?) will be download when you clone the repository in the history. It is better to separate the binaries from the source

Jorg introduced me to a site called https://bintray.com/

--
Ivan

On Fri, May 3, 2013 at 9:02 AM, Aall Spemmer <sssml2011@gmail.com mailto:sssml2011@gmail.com> wrote:

Thanks. I figured it out after looking through the PluginManager
code. I just added a releases folder to the project on GitHub and
built the zip in there. That seems to work.

-- You received this message because you are subscribed to the Google
Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to elasticsearch+unsubscribe@googlegroups.com
mailto:elasticsearch%2Bunsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com mailto:elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Thanks for the advice and the suggestion of using bintray. I have moved
the binary to bintray.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.