Does the JSON data type for CouchDB river plugin key-value pairs matter?


(pulkitsinghal) #1

A few thing are at odds in the JSON representation in the CouchDB River
plugin's readme
(https://github.com/elasticsearch/elasticsearch-river-couchdb).

For example:

{"port" : 443}

Versus:

{"bulk_size" : "100"}

Q1) Why is one a number and the other a string? Does it not matter?

Another example:

"ignore_attachments" : true

Versus:

"no_verify" : "true"

Q2) Why is one a boolean and the other a string? Does it not matter?

I just want to be super sure that I get my config right w/o any latent bugs
surfacing later :slight_smile:


(David Pilato) #2

IMHO, it's best to use the real type for each field.
As far as I can see, no_verify is a boolean. So "no_verify" : true is better.

Same for bulk size which should be {"bulk_size" : 100}.

HTH
David

Le 31 mai 2012 à 19:20, pulkitsinghal pulkitsinghal@gmail.com a écrit :

A few thing are at odds in the JSON representation in the CouchDB River plugin's readme (https://github.com/elasticsearch/elasticsearch-river-couchdb).

For example:

{"port" : 443}

Versus:

{"bulk_size" : "100"}

Q1) Why is one a number and the other a string? Does it not matter?

Another example:

"ignore_attachments" : true

Versus:

"no_verify" : "true"

Q2) Why is one a boolean and the other a string? Does it not matter?

I just want to be super sure that I get my config right w/o any latent bugs surfacing later :slight_smile:


(system) #3