Failing unit tests on a fresh fork


(Patrick Peschlow) #1

Hi,

I forked Elasticsearch in order to test a possible bugfix and followed the
instructions here
http://www.elasticsearch.org/contributing-to-elasticsearch/.
Unfortunately, running the unit tests of the fresh fork (commit
0e2d33b4a446af033db48284737a62b9cc8c99bb) via

ES_TEST_LOCAL=true mvn clean test

led to one of the randomized tests failing. I pulled a commit (
9c98bb3554367c7a09aa6b01c0b7859d8ed3c018) that appeared in the meantime, tried
again, and this time it was 2 tests failing.

Is this expected behavior - it can just happen any time that you pull and
the tests are broken? Or is there anything I need to do prior to running
the tests that I might have missed?

Regards,
Patrick

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elasticsearch/5eb896bc-9242-4a2c-8d94-602101ba4047%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


(Nik Everett) #2

Normally tests aren't broken but with randomized testing it is possible for
things to sneak through. The best thing to do in this case is to submit an
issue with the stack trace and the failing test. The stack trace will
contain the randomized seed that'll be needed to reproduce the failure.

Nik

On Fri, May 30, 2014 at 8:13 AM, Patrick Peschlow <
patrick.peschlow@codecentric.de> wrote:

Hi,

I forked Elasticsearch in order to test a possible bugfix and followed the
instructions here
http://www.elasticsearch.org/contributing-to-elasticsearch/.
Unfortunately, running the unit tests of the fresh fork (commit
0e2d33b4a446af033db48284737a62b9cc8c99bb) via

ES_TEST_LOCAL=true mvn clean test

led to one of the randomized tests failing. I pulled a commit (
9c98bb3554367c7a09aa6b01c0b7859d8ed3c018) that appeared in the meantime, tried
again, and this time it was 2 tests failing.

Is this expected behavior - it can just happen any time that you pull and
the tests are broken? Or is there anything I need to do prior to running
the tests that I might have missed?

Regards,
Patrick

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/elasticsearch/5eb896bc-9242-4a2c-8d94-602101ba4047%40googlegroups.com
https://groups.google.com/d/msgid/elasticsearch/5eb896bc-9242-4a2c-8d94-602101ba4047%40googlegroups.com?utm_medium=email&utm_source=footer
.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elasticsearch/CAPmjWd29LFvVFZYpZEY9SXpgAi-1jYA7CP1u3GekyQmWxi%2BjzA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


(Patrick Peschlow) #3

Thanks, just did that. Incidentally, in this particular case the fix was
already made while I was opening the issue :slight_smile:

On Friday, May 30, 2014 3:24:39 PM UTC+2, Nikolas Everett wrote:

Normally tests aren't broken but with randomized testing it is possible
for things to sneak through. The best thing to do in this case is to
submit an issue with the stack trace and the failing test. The stack trace
will contain the randomized seed that'll be needed to reproduce the failure.

Nik

On Fri, May 30, 2014 at 8:13 AM, Patrick Peschlow <
patrick....@codecentric.de <javascript:>> wrote:

Hi,

I forked Elasticsearch in order to test a possible bugfix and followed
the instructions here
http://www.elasticsearch.org/contributing-to-elasticsearch/.
Unfortunately, running the unit tests of the fresh fork (commit
0e2d33b4a446af033db48284737a62b9cc8c99bb) via

ES_TEST_LOCAL=true mvn clean test

led to one of the randomized tests failing. I pulled a commit (
9c98bb3554367c7a09aa6b01c0b7859d8ed3c018) that appeared in the meantime, tried
again, and this time it was 2 tests failing.

Is this expected behavior - it can just happen any time that you pull and
the tests are broken? Or is there anything I need to do prior to running
the tests that I might have missed?

Regards,
Patrick

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearc...@googlegroups.com <javascript:>.
To view this discussion on the web visit
https://groups.google.com/d/msgid/elasticsearch/5eb896bc-9242-4a2c-8d94-602101ba4047%40googlegroups.com
https://groups.google.com/d/msgid/elasticsearch/5eb896bc-9242-4a2c-8d94-602101ba4047%40googlegroups.com?utm_medium=email&utm_source=footer
.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elasticsearch/78f79843-9092-49b3-9434-96e2781c2ee3%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


(Jörg Prante) #4

When forking the master, things are expected to be quite volatile, and you
should allow the ES core team a few hours or even days to let the dust
settle down. Don't worry too much if things are temporarily broken on
master, for stable builds, there are tagged releases...

Jörg

On Fri, May 30, 2014 at 4:56 PM, Patrick Peschlow <
patrick.peschlow@codecentric.de> wrote:

Thanks, just did that. Incidentally, in this particular case the fix was
already made while I was opening the issue :slight_smile:

On Friday, May 30, 2014 3:24:39 PM UTC+2, Nikolas Everett wrote:

Normally tests aren't broken but with randomized testing it is possible
for things to sneak through. The best thing to do in this case is to
submit an issue with the stack trace and the failing test. The stack trace
will contain the randomized seed that'll be needed to reproduce the failure.

Nik

On Fri, May 30, 2014 at 8:13 AM, Patrick Peschlow <
patrick....@codecentric.de> wrote:

Hi,

I forked Elasticsearch in order to test a possible bugfix and followed
the instructions here
http://www.elasticsearch.org/contributing-to-elasticsearch/.
Unfortunately, running the unit tests of the fresh fork (commit
0e2d33b4a446af033db48284737a62b9cc8c99bb) via

ES_TEST_LOCAL=true mvn clean test

led to one of the randomized tests failing. I pulled a commit (
9c98bb3554367c7a09aa6b01c0b7859d8ed3c018) that appeared in the meantime
, tried again, and this time it was 2 tests failing.

Is this expected behavior - it can just happen any time that you pull
and the tests are broken? Or is there anything I need to do prior to
running the tests that I might have missed?

Regards,
Patrick

--
You received this message because you are subscribed to the Google
Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to elasticsearc...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/
msgid/elasticsearch/5eb896bc-9242-4a2c-8d94-602101ba4047%
40googlegroups.com
https://groups.google.com/d/msgid/elasticsearch/5eb896bc-9242-4a2c-8d94-602101ba4047%40googlegroups.com?utm_medium=email&utm_source=footer
.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/elasticsearch/78f79843-9092-49b3-9434-96e2781c2ee3%40googlegroups.com
https://groups.google.com/d/msgid/elasticsearch/78f79843-9092-49b3-9434-96e2781c2ee3%40googlegroups.com?utm_medium=email&utm_source=footer
.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elasticsearch/CAKdsXoH9SC%2BC-qpDhsCOWV7mAMLH7tBNQZ-HqR6G5Rp2%2BriQ-w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


(system) #5