Getting the value of a doc field inside FilterScript plugin

lsena · June 14, 2021, 10:20am

Hi! I need to fetch the value of the _id (or other doc fields).

Currently, I'm doing it like this:

lsena/fastfilter-elasticsearch-plugin/blob/master/src/main/java/org/elasticsearch/lsena/fastfilter/FastFilterPlugin.java#L157

    
      
          				rBitmap.deserialize(buffer);
          
          
				return new FilterScript(params, lookup, context) {
          
          
					@Override
          					public boolean execute() {
          						try {
          
          
							final int docId;
          							if (fieldName.equals("_id")) {
          								final ScriptDocValues.Strings fieldNameValue = 
          										(ScriptDocValues.Strings)getDoc().get(fieldName);
          								docId = Integer.parseInt(fieldNameValue.getValue());	
          							} else {
          								// TODO: there must be a better way to do this
          								// we do not need the whole doc, just the value
          								// TODO2: the selected field could be a string and this will explode
          								final ScriptDocValues.Longs fieldNameValue = 
          										(ScriptDocValues.Longs)getDoc().get(fieldName);
          								docId = (int)fieldNameValue.getValue();	
          							}

Is this the proper way to do it? It feels wrong. Especially fetching _id since it even throws a warning about the deprecation of using _id in aggregations.

Unfortunately, Elasticsearch plugin documentation is almost inexistent

system · July 12, 2021, 10:21am

This topic was automatically closed 28 days after the last reply. New replies are no longer allowed.