How to support facet filters in custom facets?

Other than calling addFilterFacetAndGlobal(builder, params) in the
overridden AbstractFacetBuilder.toXContent method, is there any other code
that is required in order to support facet filters in custom facets?

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Does the upcoming facet refactoring obsolete this question?

On Tuesday, February 26, 2013 3:31:21 PM UTC-8, Eric Jain wrote:

Other than calling addFilterFacetAndGlobal(builder, params) in the
overridden AbstractFacetBuilder.toXContent method, is there any other code
that is required in order to support facet filters in custom facets?

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

I think it does... here is the commit for the facet refactor:

It looks like the filter facet gets parsed and cached in:
src/main/java/org/elasticsearch/search/facet/FacetParseElement.java

It get applied in the abstract Facet Builder in the "facetFilter" and
"addFilterFacetAndGlobal" methods:
src/main/java/org/elasticsearch/search/facet/FacetBuilder.java

Looking at all the built-in facets, they all seem to duplicate the
facetFilter method though...

On Wed, Feb 27, 2013 at 3:19 PM, Eric Jain eric.jain@gmail.com wrote:

Does the upcoming facet refactoring obsolete this question?

On Tuesday, February 26, 2013 3:31:21 PM UTC-8, Eric Jain wrote:

Other than calling addFilterFacetAndGlobal(builder, params) in the
overridden AbstractFacetBuilder.toXContent method, is there any other code
that is required in order to support facet filters in custom facets?

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.