_id not being set when I pass it in my actions setup

Elastic Stack Elasticsearch
1

Not sure if I did it wrong or this is an issue, so i created one of my actions

 data_index = {
            '_op_type': 'create',
            "_index": index_name,
            "_id": code,
            "doc": ****
        }

The code was supposed to be the _id and should not be null but this data is coming from an old database and unfortunately some entries were null, Yes, Elasticsearch creates random _id but the i_d is kinda important, I do not think it should create this silently.
Is this an issue or did i do this wrong?
Thanks everyone
For more information, i was using Python - Elasticsearch client.

2

_id is mandatory in every document. So either you supply one, and clearly has to be non-null, or elasticsearch creates it (not quite randomly, but leave that aside for now).

The python client + elasticsearch seemed to do this, according to my understanding of what you wrote?

What did you want done differently? Or just do exactly the same, but more noisily ?

3

Thanks for your response, Yes it creates a random id, but yes I want it to at least warn if it does that so to use your term "noisily"

4

I don’t know the python library specifics, but if you do same via curl elasticsearch replies telling you it created a document and the _id it used.

Note this is a very typical use case, many applications don’t supply an _id and there are some downsides to using/managing _id on your own. So I’d personally not characterise a warning as being necessary. But I’m sure setting some log level to info or trace could be used.

You can of course code your application to check for non-null _id and handle those cases differently. But tons of stuff relies on elasticsearch doing exactly what it seems to have done in your scenario - so I’d characterise that it was all working consistently with its own documentation?

YOU specifically asked:

“ Is this an issue or did i do this wrong?”

and IMO the answers are no, it’s not an issue, and no, you did not do anything wrong.

5

Thank you very much, Yes I have added the check to my code!