Input wanted on source code issues,


(Koen De Groote) #1

I've been going over the source code and noticed a few things that are a bit of headscratcher. Meaning I think they're bugs or at least an oversight.

As of right now, I have 2 that I found:

  1. https://github.com/elastic/elasticsearch/blob/master/core/src/main/java/org/elasticsearch/index/mapper/DocumentParser.java#L458

It was confirmed on GitHub that the return of this is never used and the method should be re-written

  1. https://github.com/elastic/elasticsearch/blob/master/modules/aggs-matrix-stats/src/main/java/org/elasticsearch/search/aggregations/support/MultiValuesSourceParser.java#L78

On line 83, a variable valueType is made. It is never used in the while-loop below it, only to eventually hit line 150, where it is checked for null and will always be null.

What should happen in this case?


(system) #2

This topic was automatically closed 28 days after the last reply. New replies are no longer allowed.