Kubernetes.container.cpu.usage.node.pct reports capacity rather than documented allocatable usage

kevinsmithwrs · June 6, 2024, 12:43pm

Before opening a Bug, opening this issue as requested.

According to the docs here:

The kubernetes.container.cpu.usage.node.pct and kubernetes.container.memory.usage.node.pct are supposed to report the node allocatable usage percentages, however they actually report node capacity percentages.

The relevant code is here:

github.com

elastic/beats/blob/c77302852ef913c7b4e1ed521528df9a7e8ca55d/metricbeat/module/kubernetes/util/kubernetes.go#L627


      
          			id = join(namespace, id)
          		}
          
          		switch r := r.(type) {
          		case *kubernetes.Pod:
          			return map[string]mapstr.M{id: specificMetaGen.Generate(r)}
          
          		case *kubernetes.Node:
          			nodeName := r.GetObjectMeta().GetName()
          			metrics := NewNodeMetrics()
          			if cpu, ok := r.Status.Capacity["cpu"]; ok {
          				if q, err := resource.ParseQuantity(cpu.String()); err == nil {
          					metrics.CoresAllocatable = NewFloat64Metric(float64(q.MilliValue()) / 1000)
          				}
          			}
          			if memory, ok := r.Status.Capacity["memory"]; ok {
          				if q, err := resource.ParseQuantity(memory.String()); err == nil {
          					metrics.MemoryAllocatable = NewFloat64Metric(float64(q.Value()))
          				}
          			}
          			nodeStore, _ := metricsRepo.AddNodeStore(nodeName)

Indeed changing the the code from "Capacity" to "Allocatable" in the line above fixes the problem. I notice the Memory usage calculation is also likewise incorrect on line 632 of the above source.

Can this be fixed please?

Thanks,

Kevin

Topic		Replies	Views
Kubernetes module not getting resource limits Beats metricbeat	8	1419	March 16, 2019
Kubernetes: collecting allocate resource percentages for nodes Beats metricbeat	1	353	February 2, 2020
No metric kubernetes.pod.cpu.usage.limit.pct in event output Beats metricbeat	4	784	June 13, 2019
There are wrong values with memory usage in kubernetes metricbeat module Beats	5	738	December 22, 2021
`kubernetes.volume.fs.used.pct` has incorrect type in index template Beats fleet , metricbeat	3	465	December 29, 2021

Kubernetes.container.cpu.usage.node.pct reports capacity rather than documented allocatable usage

Related topics