Labels missing from Namespace definition in 1.6.0

[pkaramol (Pantelis Karamolegkos)]

The Namespace definition in 1.5.0 is the following:

# Source: eck-operator/templates/operator-namespace.yaml
apiVersion: v1
kind: Namespace
metadata:
  name: elastic-system
  labels:
    name: elastic-system
    control-plane: elastic-operator
    app.kubernetes.io/version: "1.5.0"

In 1.6.0 it becomes as follows:

# Source: eck-operator/templates/operator-namespace.yaml
apiVersion: v1
kind: Namespace
metadata:
  name: elastic-system
  labels:
    name: elastic-system

Is the removal of those 2 labels intentional?

    control-plane: elastic-operator
    app.kubernetes.io/version: "1.5.0"

[pebrc (Peter Brachwitz)]

Yes this was an intentional change to remove an incompatibility with istio. See Istio sidecar is not injected into operator automatically · Issue #4395 · elastic/cloud-on-k8s · GitHub for context.

[pkaramol (Pantelis Karamolegkos)]

I had no problem injecting istio with 1.5.0. (I am in the process of upgrading to 1.6.0)

This (1.5.0) was my first installation (the version I started with) however (not an upgrade) fwiw.

▶ istioctl version --remote
client version: 1.9.4
control plane version: 1.9.5
data plane version: 1.9.5 (116 proxies)
                                                                                                                                                                                      2h15m  
▶ kubectl get pods -n elastic-system -o jsonpath="{.items[*].spec.containers[*].name}" |\
tr -s '[[:space:]]' '\n' |\
sort |\
uniq -c
   1 istio-proxy
   1 manager

▶ k get pods -n elastic-system                                                           
NAME                 READY   STATUS    RESTARTS   AGE
elastic-operator-0   2/2     Running   0          3d3h

▶ k get es                    
NAME            HEALTH   NODES   VERSION   PHASE   AGE
mycluster   green    3       7.12.1    Ready   4d4h

▶ kubectl get pods -n elastic-system -o jsonpath="{.items[*].spec.containers[*].image}" |\
tr -s '[[:space:]]' '\n'
docker.io/istio/proxyv2:1.9.5
docker.elastic.co/eck/eck-operator:1.5.0