Modify plugins filename


(David Pilato) #1

Heya,

Short story :

I'm working on assembly maven plugin as releasing plugins with the latest
maven assembly plugin will not work anymore.

Is there any problem if we rename artifacts generated by assembly from
elasticsearch-river-couchdb-1.2.0-SNAPSHOT.zip to
elasticsearch-river-couchdb-1.2.0-SNAPSHOT-plugin.zip ?

Long story :

Maven 3 set some defaults plugin versions. Maven assembly is by default
2.2-beta5.

This version allows to have empty in the assembly file.

Starting with 2.2.1, it's not allowed anymore. Latest version is 2.3 and
does not allow it also.

So if we define plugin, it add plugin as a classifier for the zip
file.

So, is it a problem for plugin.sh and plugin.bat commands ? Will be any
other issues ?

If so, what is the best way to solve that ? Modify the plugin tool to try to
download also pluginname-version-*.zip ?

Try to modify pom.xml and/or plugin.xml files to fix that on the maven side
?

Please let me know. I will try to push fixes for that soon.

David.


(Shay Banon) #2

I fixed it in the relevant pom's of the current plugins, you can simply state that the id won't be appended to the resulting archive.

On Saturday, February 25, 2012 at 3:12 PM, David Pilato wrote:

Heya,

Short story :

I’m working on assembly maven plugin as releasing plugins with the latest maven assembly plugin will not work anymore.

Is there any problem if we rename artifacts generated by assembly from elasticsearch-river-couchdb-1.2.0-SNAPSHOT.zip to elasticsearch-river-couchdb-1.2.0-SNAPSHOT-plugin.zip ?

Long story :

Maven 3 set some defaults plugin versions. Maven assembly is by default 2.2-beta5.

This version allows to have empty in the assembly file.

Starting with 2.2.1, it’s not allowed anymore. Latest version is 2.3 and does not allow it also.

So if we define plugin, it add plugin as a classifier for the zip file.

So, is it a problem for plugin.sh (http://plugin.sh) and plugin.bat commands ? Will be any other issues ?

If so, what is the best way to solve that ? Modify the plugin tool to try to download also pluginname-version-*.zip ?

Try to modify pom.xml and/or plugin.xml files to fix that on the maven side ?

Please let me know. I will try to push fixes for that soon.

David.


(David Pilato) #3

Thanks Shay !

In fact, that's what I did some weeks ago in the rss river plugin but I wasn't remembering that I did it before :frowning: Shame on me :wink:

David :wink:
@dadoonet

Le 26 févr. 2012 à 20:38, Shay Banon kimchy@gmail.com a écrit :

I fixed it in the relevant pom's of the current plugins, you can simply state that the id won't be appended to the resulting archive.
On Saturday, February 25, 2012 at 3:12 PM, David Pilato wrote:

Heya,

Short story :
I’m working on assembly maven plugin as releasing plugins with the latest maven assembly plugin will not work anymore.
Is there any problem if we rename artifacts generated by assembly from elasticsearch-river-couchdb-1.2.0-SNAPSHOT.zip to elasticsearch-river-couchdb-1.2.0-SNAPSHOT-plugin.zip ?

Long story :
Maven 3 set some defaults plugin versions. Maven assembly is by default 2.2-beta5.
This version allows to have empty in the assembly file.

Starting with 2.2.1, it’s not allowed anymore. Latest version is 2.3 and does not allow it also.

So if we define plugin, it add plugin as a classifier for the zip file.

So, is it a problem for plugin.sh and plugin.bat commands ? Will be any other issues ?
If so, what is the best way to solve that ? Modify the plugin tool to try to download also pluginname-version-*.zip ?
Try to modify pom.xml and/or plugin.xml files to fix that on the maven side ?

Please let me know. I will try to push fixes for that soon.

David.


(system) #4