Node plugin not propagating requests


(Ivan Brusic) #1

Creating a new plugin that works on the node (JVM) level.

The node that receives a request executes the request perfectly, but the
other nodes do not get the request.

In my TransportNodesOperationAction subclass, I implemented the two methods:
protected abstract NodeRequest newNodeRequest();
protected abstract NodeRequest newNodeRequest(String nodeId, Request
request);

Execute the action via:
client.admin().cluster().execute(MyAction.INSTANCE, request, new
ActionListener() { ...})

When calling the new ClusterAction, the first node executes the
newNodeRequest with the Request as a param. The other node gets the empty
call. The correct method call occurs inside the AsyncAction.start() method.
From my logging, my NodesOperationRequestBuilder never execute
its doExecute() method.

@Override
protected void doExecute(ActionListener<MyResponse> listener) {

((ClusterAdminClient) client).execute(MyrAction.INSTANCE, request,
listener);
}

Not sure what I have missed. All classes subclass from the NodesOperation
heirarchy (except for the Action which subclasses ClusterAction).
executor() returns ThreadPool.Names.MANAGEMENT.

Cheers,

Ivan

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Jörg Prante) #2

Can you share more than just code fragments, it's hard to find out what is
going on.

Jörg

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Ivan Brusic) #3

There are at least 7 different public classes needed for the plugin, and I
don't have them in any public repo. Any specific class?

On Wed, Sep 18, 2013 at 1:20 PM, joergprante@gmail.com <
joergprante@gmail.com> wrote:

Can you share more than just code fragments, it's hard to find out what is
going on.

Jörg

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Ivan Brusic) #4

A few trimmed files: https://gist.github.com/brusic/05c5af4c12357e8e49e5

On Wed, Sep 18, 2013 at 2:50 PM, Ivan Brusic ivan@brusic.com wrote:

There are at least 7 different public classes needed for the plugin, and I
don't have them in any public repo. Any specific class?

On Wed, Sep 18, 2013 at 1:20 PM, joergprante@gmail.com <
joergprante@gmail.com> wrote:

Can you share more than just code fragments, it's hard to find out what
is going on.

Jörg

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Ivan Brusic) #5

Is there anyone beside Jörg that knows elasticsearch internals?

On Wed, Sep 18, 2013 at 3:45 PM, Ivan Brusic ivan@brusic.com wrote:

A few trimmed files: https://gist.github.com/brusic/05c5af4c12357e8e49e5

On Wed, Sep 18, 2013 at 2:50 PM, Ivan Brusic ivan@brusic.com wrote:

There are at least 7 different public classes needed for the plugin, and
I don't have them in any public repo. Any specific class?

On Wed, Sep 18, 2013 at 1:20 PM, joergprante@gmail.com <
joergprante@gmail.com> wrote:

Can you share more than just code fragments, it's hard to find out what
is going on.

Jörg

--
You received this message because you are subscribed to the Google
Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Ivan Brusic) #6

Serialization. Duh. I made some assumptions that simply were not true. I
will write-up my findings for anyone interested in writing node-level
plugins in the future.

--
Ivan

On Thu, Sep 19, 2013 at 10:38 AM, Ivan Brusic ivan@brusic.com wrote:

Is there anyone beside Jörg that knows elasticsearch internals?

On Wed, Sep 18, 2013 at 3:45 PM, Ivan Brusic ivan@brusic.com wrote:

A few trimmed files: https://gist.github.com/brusic/05c5af4c12357e8e49e5

On Wed, Sep 18, 2013 at 2:50 PM, Ivan Brusic ivan@brusic.com wrote:

There are at least 7 different public classes needed for the plugin, and
I don't have them in any public repo. Any specific class?

On Wed, Sep 18, 2013 at 1:20 PM, joergprante@gmail.com <
joergprante@gmail.com> wrote:

Can you share more than just code fragments, it's hard to find out what
is going on.

Jörg

--
You received this message because you are subscribed to the Google
Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Lukáš Vlček) #7

I will write-up my findings for anyone interested in writing node-level
plugins in the future.

+1

btw, my colleague Vlastimil implemented plugin that might be worth looking
at [1]. I am not too familiar with its internals but IIRC he had to go down
the similar road.

[1] https://github.com/jbossorg/elasticsearch-river-jira

Regards,
Lukas

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Ivan Brusic) #8

Thanks Lukas.

My first plugin was a river plugin and that was three years ago. River
plugins are far easier since all the node communication is handled by the
RiverModule. Since then I have created other plugins (river and analysis),
but nothing at the node level.

Basically all data shared between nodes is serialized in the
readFrom/writeTo methods of the NodeOperationRequest object. Since this
class takes a NodesOperationRequest (note the different classname) as an
arg in the constructor, I assumed that it would correctly serialize the
request. However this obviously was not the case, which makes sense in
hindsight. How can my subclass be automatically serialized if I added new
fields? There are two different request classes and two different response
classes, so it was hard to spot the issue without stepping back and looking
at the class hierarchy as a whole.

--
Ivan

On Fri, Sep 20, 2013 at 12:00 AM, Lukáš Vlček lukas.vlcek@gmail.com wrote:

I will write-up my findings for anyone interested in writing node-level

plugins in the future.

+1

btw, my colleague Vlastimil implemented plugin that might be worth looking
at [1]. I am not too familiar with its internals but IIRC he had to go down
the similar road.

[1] https://github.com/jbossorg/elasticsearch-river-jira

Regards,
Lukas

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Lukáš Vlček) #9

Hi Ivan,

yes I agree, but let me explain why I pointed out the JIRA river.

Rivers are relatively easy that is true - but only as long as you are fine
with its basic contract, i.e. start() and close() operations. Once you want
more fine grained control of your river then it gets more complicated. In
our rivers: JIRA river [1] and Remote river [2] (both are basically
similar, the former is just more specific to JIRA as a data source) we also
wanted to provide REST API for management of individual river instances and
reporting status [3]. Extending REST API is again simple - by registering
new actions on RestModule. But the question is what should happen when the
REST request is received on the node which is not running the river
singleton. Now, from what I have seen there are basically two approaches
how ppl do go about this.

The first one is to store client action as a document into cluster (for
example into _river index) and have the river check for such documents in
periodic intervals. The river uses the search API to learn if there was any
request to execute some specific action.

The second way (which we used) is a bit different. In nutshell it includes
full propagation from RestRequest to ClusterAction (and this includes
NodeOperationRequest/Response serialization as well). I think this provides
better options in terms of river control and reporting the status from
river.

May be there are better ways of doing this but as of now we do not know
about them. Also I am not aware of any other plugin that would do it in
similar way. It took Vlastimil quite some work to get there, one of the
biggest issues was missing Javadoc and relevant documentation.

So now I hope it makes more sense why I pointed you to the JIRA river :slight_smile:

Regards,
Lukas

[1] https://github.com/jbossorg/elasticsearch-river-jira
[2] https://github.com/jbossorg/elasticsearch-river-remote
[3] https://github.com/jbossorg/elasticsearch-river-jira#management-rest-api

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Ivan Brusic) #10

Hi Lukáš,

I did not dig deep enough into the code. I now see that the relevant
classes are inside the subfolders of mgm. Since there are many classes to
implement, once I did not see the explosion of classes in jira or mgm I
assumed it was just a standard river.

My implementation has been working smoothly, but I will still look at the
code to see if there is anything else that can be learned.

It did take quite some work to figure out since there is no documentation.
:slight_smile: Have not seen any other plugins that work at the node level, at least
not at a glance (such as the JIRA river). I want to implement some of the
other types of TransportActions just to see how they behave and how they
differ from each other. For example, what is the difference
between TransportSingleCustomOperationAction
and TransportBroadcastOperationAction?

Cheers,

Ivan

On Tue, Sep 24, 2013 at 1:37 PM, Lukáš Vlček lukas.vlcek@gmail.com wrote:

Hi Ivan,

yes I agree, but let me explain why I pointed out the JIRA river.

Rivers are relatively easy that is true - but only as long as you are fine
with its basic contract, i.e. start() and close() operations. Once you want
more fine grained control of your river then it gets more complicated. In
our rivers: JIRA river [1] and Remote river [2] (both are basically
similar, the former is just more specific to JIRA as a data source) we also
wanted to provide REST API for management of individual river instances and
reporting status [3]. Extending REST API is again simple - by registering
new actions on RestModule. But the question is what should happen when the
REST request is received on the node which is not running the river
singleton. Now, from what I have seen there are basically two approaches
how ppl do go about this.

The first one is to store client action as a document into cluster (for
example into _river index) and have the river check for such documents in
periodic intervals. The river uses the search API to learn if there was any
request to execute some specific action.

The second way (which we used) is a bit different. In nutshell it includes
full propagation from RestRequest to ClusterAction (and this includes
NodeOperationRequest/Response serialization as well). I think this provides
better options in terms of river control and reporting the status from
river.

May be there are better ways of doing this but as of now we do not know
about them. Also I am not aware of any other plugin that would do it in
similar way. It took Vlastimil quite some work to get there, one of the
biggest issues was missing Javadoc and relevant documentation.

So now I hope it makes more sense why I pointed you to the JIRA river :slight_smile:

Regards,
Lukas

[1] https://github.com/jbossorg/elasticsearch-river-jira
[2] https://github.com/jbossorg/elasticsearch-river-remote
[3]
https://github.com/jbossorg/elasticsearch-river-jira#management-rest-api

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(system) #11