Plugin development: custom distribution for yamlRestTest ? (7.16)

mhugo · January 25, 2022, 3:55pm

Hi,

I'm migrating a plugin to the last 7.16.3 version and have trouble figuring out how to make yaml REST tests pass. The ES distribution that is used to run these tests does not seem to include everything needed to run my tests.

This is a plugin that adds geometry computation (simplification) thanks to JTS. The ES distribution used for yamlRestTests (this one if I am correct) does not include geo dependencies (namely legacy-geo, jts and its dependencies).

I am not very comfortable with Gradle, but would there be a simple way to add plugins to the ES distribution before running tests ? or use another custom distribution ?

Thanks in advance for your help.

Ignacio_Vera · January 26, 2022, 3:55pm

It should be a syntax similar to what we have done here:

github.com

elastic/elasticsearch/blob/c8ceda800706eafe503e84c1044c58ae0e04ee9b/x-pack/plugin/vector-tile/build.gradle#L35

      
        
            
            
dependencies {
              compileOnly project(path: xpackModule('core'))
              compileOnly project(path: xpackModule('spatial'))
              testImplementation(testArtifact(project(xpackModule('core'))))
              compileOnly "org.locationtech.jts:jts-core:${versions.jts}"
              api "com.wdtinc:mapbox-vector-tile:3.1.0"
              api "com.google.protobuf:protobuf-java:3.14.0"
              runtimeOnly("org.slf4j:slf4j-api:${versions.slf4j}")
              runtimeOnly("org.apache.logging.log4j:log4j-slf4j-impl:${versions.log4j}")
              javaRestTestImplementation("com.wdtinc:mapbox-vector-tile:3.1.0")
              javaRestTestImplementation("com.google.protobuf:protobuf-java:3.14.0")
            }
            
            
testClusters.configureEach {
              setting 'xpack.license.self_generated.type', 'trial'
              testDistribution = 'DEFAULT'
              setting 'xpack.security.enabled', 'false'
            }
            
            
tasks.named("thirdPartyAudit").configure {

I think for yaml test there is a yamlRestTestImplementation call.

mhugo · January 27, 2022, 9:41am

Thanks for your answer.

However, I've already tried to add dependencies to yamlRestTestImplementation. It does resolve problems during compilation of tests, but has no effect during execution of tests.

If I add yamlRestTestImplementation "org.locationtech.jts:jts-core:1.15.0", I still get an error when the tests are launched: java.lang.NoClassDefFoundError: org/locationtech/jts/io/ParseException. I think this is because the ES distribution used for tests is very minimal and does not include these dependencies.

In 6.8, we used to add testClusters.all { testDistribution = 'oss'} so that tests were running on a full-blown OSS distribution of ES (with all dependencies already loaded). But I was not able to find an equivalent in 7.16

mhugo · January 27, 2022, 9:43am

Hmm it seems testCulsters.all { testDistribution = 'DEFAULT' } uses a "complete" ES distribution for running tests and gives better results in my case ... (the legacy geo module is here and tests seem to be launched).
So it means 'INTEG_TEST' is the default value ("DEFAULT" is not the default value ...)

system · February 24, 2022, 9:44am

This topic was automatically closed 28 days after the last reply. New replies are no longer allowed.