Remove search type: query_and_fetch


(Shay Banon) #1

Heya,

I am working on some refactoring both in the facets area specifically

and in search in general. I an planning to remove the option to have a
search_type of query_and_fetch, since I find it less useful than I thought
initially (you almost never want to use it). Ping if you still want it in,
and why.

-shay.banon


(Karussell) #2

Hi Shay,

isn't this search type the fastest when I expect only a few hits? E.g.
when user id is the user name but the user document can also retrieved
via twitter token.

What is the reason you want remove that? Is that regarding the facets
problem in issue 1305?

Regards,
Peter.

On 3 Nov., 00:10, Shay Banon kim...@gmail.com wrote:

Heya,

I am working on some refactoring both in the facets area specifically

and in search in general. I an planning to remove the option to have a
search_type of query_and_fetch, since I find it less useful than I thought
initially (you almost never want to use it). Ping if you still want it in,
and why.

-shay.banon


(frazer) #3

Hey Shay

Is the refactoring to improve performance?

On Nov 2, 7:10 pm, Shay Banon kim...@gmail.com wrote:

Heya,

I am working on some refactoring both in the facets area specifically

and in search in general. I an planning to remove the option to have a
search_type of query_and_fetch, since I find it less useful than I thought
initially (you almost never want to use it). Ping if you still want it in,
and why.

-shay.banon


(Shay Banon) #4

On Thu, Nov 3, 2011 at 10:18 AM, Karussell tableyourtime@googlemail.comwrote:

Hi Shay,

isn't this search type the fastest when I expect only a few hits? E.g.
when user id is the user name but the user document can also retrieved
via twitter token.

Yes, if the request goes to several shards, then it will be faster if there
are "few" results, but not terribly faster.

What is the reason you want remove that? Is that regarding the facets
problem in issue 1305?

Thats one of them (the issue), I want to improve the search execution to
make it both simpler to maintain, as well as simpler to extend.

Regards,
Peter.

On 3 Nov., 00:10, Shay Banon kim...@gmail.com wrote:

Heya,

I am working on some refactoring both in the facets area specifically

and in search in general. I an planning to remove the option to have a
search_type of query_and_fetch, since I find it less useful than I
thought
initially (you almost never want to use it). Ping if you still want it
in,
and why.

-shay.banon


(system) #5