River unit test failing with ES 0.90.6


(Richard Louapre) #1

Hi,

I try to migrate my plugin to ES 0.90.6 but most of my unit tests fail.

I have create a simple dummy river [1] that also fail with 0.90.6 but pass
with 0.90.5 (change ES version in pom.xml).

It looks like something has been changed in the way river are registered
and then started during unit test.

Any advice on what has been changed on to make unit test working with ES
0.90.6?

[1] - https://github.com/richardwilly98/my-dummy-river/tree/master

Thanks,
Richard.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Luca Cavanna) #2

Hi,
sounds weird, what kind of failures do you get? I quickly tried updating a
river that I wrote a while ago and didn't have issues.

On Tuesday, November 5, 2013 10:43:38 AM UTC+1, Richard Louapre wrote:

Hi,

I try to migrate my plugin to ES 0.90.6 but most of my unit tests fail.

I have create a simple dummy river [1] that also fail with 0.90.6 but pass
with 0.90.5 (change ES version in pom.xml).

It looks like something has been changed in the way river are registered
and then started during unit test.

Any advice on what has been changed on to make unit test working with ES
0.90.6?

[1] - https://github.com/richardwilly98/my-dummy-river/tree/master

Thanks,
Richard.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Richard Louapre) #3

Basically the river is registered but ES does not call River.start() method.

Thanks,
Richard.

On Tuesday, November 5, 2013 8:57:29 AM UTC-5, Luca Cavanna wrote:

Hi,
sounds weird, what kind of failures do you get? I quickly tried updating a
river that I wrote a while ago and didn't have issues.

On Tuesday, November 5, 2013 10:43:38 AM UTC+1, Richard Louapre wrote:

Hi,

I try to migrate my plugin to ES 0.90.6 but most of my unit tests fail.

I have create a simple dummy river [1] that also fail with 0.90.6 but
pass with 0.90.5 (change ES version in pom.xml).

It looks like something has been changed in the way river are registered
and then started during unit test.

Any advice on what has been changed on to make unit test working with ES
0.90.6?

[1] - https://github.com/richardwilly98/my-dummy-river/tree/master

Thanks,
Richard.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(David Pilato) #4

May be a stupid question. Did you mvn clean before launching your tests?

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 5 nov. 2013 à 15:13, Richard Louapre richard.louapre@gmail.com a écrit :

Basically the river is registered but ES does not call River.start() method.

Thanks,
Richard.

On Tuesday, November 5, 2013 8:57:29 AM UTC-5, Luca Cavanna wrote:

Hi,
sounds weird, what kind of failures do you get? I quickly tried updating a river that I wrote a while ago and didn't have issues.

On Tuesday, November 5, 2013 10:43:38 AM UTC+1, Richard Louapre wrote:

Hi,

I try to migrate my plugin to ES 0.90.6 but most of my unit tests fail.

I have create a simple dummy river [1] that also fail with 0.90.6 but pass with 0.90.5 (change ES version in pom.xml).

It looks like something has been changed in the way river are registered and then started during unit test.

Any advice on what has been changed on to make unit test working with ES 0.90.6?

[1] - https://github.com/richardwilly98/my-dummy-river/tree/master

Thanks,
Richard.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Richard Louapre) #5

Always :wink:

On Tuesday, November 5, 2013 9:53:17 AM UTC-5, David Pilato wrote:

May be a stupid question. Did you mvn clean before launching your tests?

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 5 nov. 2013 à 15:13, Richard Louapre <richard...@gmail.com<javascript:>>
a écrit :

Basically the river is registered but ES does not call River.start()
method.

Thanks,
Richard.

On Tuesday, November 5, 2013 8:57:29 AM UTC-5, Luca Cavanna wrote:

Hi,
sounds weird, what kind of failures do you get? I quickly tried updating
a river that I wrote a while ago and didn't have issues.

On Tuesday, November 5, 2013 10:43:38 AM UTC+1, Richard Louapre wrote:

Hi,

I try to migrate my plugin to ES 0.90.6 but most of my unit tests fail.

I have create a simple dummy river [1] that also fail with 0.90.6 but
pass with 0.90.5 (change ES version in pom.xml).

It looks like something has been changed in the way river are registered
and then started during unit test.

Any advice on what has been changed on to make unit test working with ES
0.90.6?

[1] - https://github.com/richardwilly98/my-dummy-river/tree/master

Thanks,
Richard.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearc...@googlegroups.com <javascript:>.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Richard Louapre) #6

I have enabled DEBUG log level.

Here is the sequence for 0.90.5:
2013-11-05 10:24:57,460 INFO org.elasticsearch.cluster.metadata -
[Ka-Zar] [_river] creating index, cause [auto(index api)], shards [1]/[0],
mappings []
2013-11-05 10:24:57,468 DEBUG org.elasticsearch.river.cluster - [Ka-Zar]
processing [reroute_rivers_node_changed]: execute
2013-11-05 10:24:57,469 DEBUG org.elasticsearch.river.cluster - [Ka-Zar]
processing [reroute_rivers_node_changed]: no change in cluster_state
2013-11-05 10:24:57,613 DEBUG org.elasticsearch.river.cluster - [Ka-Zar]
processing [reroute_rivers_node_changed]: execute
2013-11-05 10:24:57,613 DEBUG org.elasticsearch.river.cluster - [Ka-Zar]
processing [reroute_rivers_node_changed]: no change in cluster_state
2013-11-05 10:24:57,705 INFO
org.elasticsearch.com.github.richardwilly98.elasticsearch.MyDummyRiverTest

  • Done Cluster Health, status GREEN
    2013-11-05 10:24:57,707 INFO org.elasticsearch.cluster.metadata -
    [Ka-Zar] [_river] update_mapping [my-dummy-river-1383665094926] (dynamic)
    2013-11-05 10:24:57,709 DEBUG org.elasticsearch.river.cluster - [Ka-Zar]
    processing [reroute_rivers_node_changed]: execute
    2013-11-05 10:24:57,711 DEBUG org.elasticsearch.river.cluster - [Ka-Zar]
    cluster state updated, version [1], source [reroute_rivers_node_changed]

    2013-11-05 10:24:57,712 DEBUG org.elasticsearch.river.cluster - [Ka-Zar]
    processing [reroute_rivers_node_changed]: done applying updated
    cluster_state
    2013-11-05 10:24:57,713 DEBUG org.elasticsearch.river - [Ka-Zar] creating
    river [my-dummy-river][my-dummy-river-1383665094926]
    2013-11-05 10:24:57,716 INFO
    org.elasticsearch.com.github.richardwilly98.elasticsearch.MyDummyRiver -
    [Ka-Zar] [my-dummy-river][my-dummy-river-1383665094926] start:
    my-dummy-river-1383665094926

Here is the sequence for 0.90.6:
2013-11-05 10:29:17,607 INFO org.elasticsearch.cluster.metadata - [Vegas]
[_river] creating index, cause [auto(index api)], shards [1]/[0], mappings
[]
2013-11-05 10:29:17,754 DEBUG org.elasticsearch.river.cluster - [Vegas]
processing [reroute_rivers_node_changed]: execute
2013-11-05 10:29:17,754 DEBUG org.elasticsearch.river.cluster - [Vegas]
processing [reroute_rivers_node_changed]: no change in cluster_state
2013-11-05 10:29:17,784 DEBUG org.elasticsearch.river.cluster - [Vegas]
processing [reroute_rivers_node_changed]: execute
2013-11-05 10:29:17,784 DEBUG org.elasticsearch.river.cluster - [Vegas]
processing [reroute_rivers_node_changed]: no change in cluster_state
2013-11-05 10:29:17,859 INFO org.elasticsearch.cluster.metadata - [Vegas]
[_river] update_mapping [my-dummy-river-1383665355042] (dynamic)
2013-11-05 10:29:17,863 DEBUG org.elasticsearch.river.cluster - [Vegas]
processing [reroute_rivers_node_changed]: execute
2013-11-05 10:29:17,865 DEBUG org.elasticsearch.river.cluster - [Vegas]
processing [reroute_rivers_node_changed]: no change in cluster_state
2013-11-05 10:29:17,884 INFO
org.elasticsearch.com.github.richardwilly98.elasticsearch.MyDummyRiverTest

  • Done Cluster Health, status GREEN
    2013-11-05 10:29:17,946 ERROR
    org.elasticsearch.com.github.richardwilly98.elasticsearch.MyDummyRiverTest
  • testRiverStarted failed.

reroute_rivers_node_changed seems to be missing.

Thanks,
Richard.

On Tuesday, November 5, 2013 10:11:07 AM UTC-5, Richard Louapre wrote:

Always :wink:

On Tuesday, November 5, 2013 9:53:17 AM UTC-5, David Pilato wrote:

May be a stupid question. Did you mvn clean before launching your tests?

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 5 nov. 2013 à 15:13, Richard Louapre richard...@gmail.com a écrit :

Basically the river is registered but ES does not call River.start()
method.

Thanks,
Richard.

On Tuesday, November 5, 2013 8:57:29 AM UTC-5, Luca Cavanna wrote:

Hi,
sounds weird, what kind of failures do you get? I quickly tried updating
a river that I wrote a while ago and didn't have issues.

On Tuesday, November 5, 2013 10:43:38 AM UTC+1, Richard Louapre wrote:

Hi,

I try to migrate my plugin to ES 0.90.6 but most of my unit tests fail.

I have create a simple dummy river [1] that also fail with 0.90.6 but
pass with 0.90.5 (change ES version in pom.xml).

It looks like something has been changed in the way river are
registered and then started during unit test.

Any advice on what has been changed on to make unit test working with
ES 0.90.6?

[1] - https://github.com/richardwilly98/my-dummy-river/tree/master

Thanks,
Richard.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearc...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Jörg Prante) #7

Same here, trying to update JDBC river to 0.90.6. It does not execute the
start method.

Am I doing something wrong?

Debug log:

Jörg

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(Jörg Prante) #8

Issue created at https://github.com/elasticsearch/elasticsearch/issues/4089

Jörg

On Tue, Nov 5, 2013 at 4:45 PM, joergprante@gmail.com <joergprante@gmail.com

wrote:

Same here, trying to update JDBC river to 0.90.6. It does not execute the
start method.

Am I doing something wrong?

Debug log:

https://gist.github.com/jprante/7321028

Jörg

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(system) #9