Sanity check fails for plugin if upgrading to Elasticsearch 6.4

Alexander_Koval · September 7, 2018, 9:47am

I have a plugin: russian & ukrainian language analyzer
It has a multiproject configuration.

When I tried to upgrade it against Elasticsearch 6.4 I got errors when running tests:

:dawg:test -> class org.gradle.api.tasks.testing.Test_Decorated                                                                                                                                                  
:jmorphy2-core:test -> class org.gradle.api.tasks.testing.Test_Decorated                                                                                                                                         
:jmorphy2-dicts-ru:test -> class org.gradle.api.tasks.testing.Test_Decorated                                                                                                                                     
:jmorphy2-dicts-uk:test -> class org.gradle.api.tasks.testing.Test_Decorated                                                                                                                                     
:jmorphy2-lucene:test -> class org.gradle.api.tasks.testing.Test_Decorated                                                                                                                                       
:jmorphy2-nlp:test -> class org.gradle.api.tasks.testing.Test_Decorated                                                                                                                                          
:jmorphy2-solr:test -> class org.gradle.api.tasks.testing.Test_Decorated                                                                                                                                         
    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)                                                                                                                
    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)                                                                                         
    at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)                                                                                 
    at com.carrotsearch.gradle.junit4.RandomizedTestingPlugin$_configureSanityCheck_closure1.doCall(RandomizedTestingPlugin.groovy:38)
    ...

As I understand Elasticsearch test runner scans all projects and complains there are non RandomizedTestingTask test tasks:

github.com

elastic/elasticsearch/blob/v6.4.0/buildSrc/src/main/groovy/com/carrotsearch/gradle/junit4/RandomizedTestingPlugin.groovy#L34


    configureSanityCheck(project)
}


private static void configureSanityCheck(Project project) {
    // Check the task graph to confirm tasks were indeed replaced
    // https://github.com/elastic/elasticsearch/issues/31324
    if (sanityCheckConfigured.getAndSet(true) == false) {
        project.rootProject.getGradle().getTaskGraph().whenReady {
            List<Task> nonConforming = project.getGradle().getTaskGraph().allTasks
                    .findAll { it.name == "test" }
                    .findAll { (it instanceof RandomizedTestingTask) == false}
                    .collect { "${it.path} -> ${it.class}" }
            if (nonConforming.isEmpty() == false) {
                throw new GradleException("Found the ${nonConforming.size()} `test` tasks:" +
                        "\n  ${nonConforming.join("\n  ")}")
            }
        }
    }
}


/**

Are there a way to fix the problem without moving the plugin into independent project?

rjernst · September 8, 2018, 7:47pm

Thanks for reporting this! It is a bug, and I've opened a PR to fix: https://github.com/elastic/elasticsearch/pull/33544

system · October 6, 2018, 7:47pm

This topic was automatically closed 28 days after the last reply. New replies are no longer allowed.