Source distribution


(Shay Banon) #1

Hi,

I have just pushed a change to the build so the source files will be
within the actual distribution jar (elasticsearch-XXX.jar). It does mean
that jar is a bit bigger, but I think its helpful for java developers out
there. Once attaching it as source, you get javadoc and source in IDEAs.
What do you think?

-shay.banon

p.s.

I am working on the maven thingy, hope to resolve this soon. Probably it
will not be on central though...


#2

Excellent! (but then again, you knew that :wink: )

-Nick

On 1 April 2010 21:16, Shay Banon shay.banon@elasticsearch.com wrote:

Hi,

I have just pushed a change to the build so the source files will be
within the actual distribution jar (elasticsearch-XXX.jar). It does mean
that jar is a bit bigger, but I think its helpful for java developers out
there. Once attaching it as source, you get javadoc and source in IDEAs.
What do you think?

-shay.banon

p.s.

I am working on the maven thingy, hope to resolve this soon. Probably it
will not be on central though...


(Paolo Castagna) #3

Good news. Thanks.

For Maven, it might be better to have separate artifacts for byte code,
sources and javadocs.

Paolo

Shay Banon wrote:

Hi,

I have just pushed a change to the build so the source files will be
within the actual distribution jar (elasticsearch-XXX.jar). It does mean
that jar is a bit bigger, but I think its helpful for java developers
out there. Once attaching it as source, you get javadoc and source in
IDEAs. What do you think?

-shay.banon

p.s.

I am working on the maven thingy, hope to resolve this soon. Probably
it will not be on central though...


(Shay Banon) #4

Don't think I am going to do that for maven... . The jar file itself will
also hold the code, source (and javadoc).

-shay.banon

On Fri, Apr 2, 2010 at 4:38 PM, Paolo Castagna <
castagna.lists@googlemail.com> wrote:

Good news. Thanks.

For Maven, it might be better to have separate artifacts for byte code,
sources and javadocs.

Paolo

Shay Banon wrote:

Hi,

I have just pushed a change to the build so the source files will be
within the actual distribution jar (elasticsearch-XXX.jar). It does mean
that jar is a bit bigger, but I think its helpful for java developers out
there. Once attaching it as source, you get javadoc and source in IDEAs.
What do you think?

-shay.banon

p.s.

I am working on the maven thingy, hope to resolve this soon. Probably it
will not be on central though...


(Paolo Castagna) #5

Shay Banon wrote:

Don't think I am going to do that for maven... . The jar file itself
will also hold the code, source (and javadoc).

This will probably cause problems to people wanting to use plugins
such as:

And everybody else who rely on the "conventions" in place:

"If you browse the Maven central repository, you will notice
that the classifiers sources and javadoc are used to deploy
the project source code and API docs along with the packaged
class files."
-- http://maven.apache.org/pom.html#POM_Relationships

Paolo


(Shay Banon) #6

I agree, but for people who use Ivy (and build systems that use Ivy
internally), they will run into problems with source/javadoc separate jar
files (it does not support that...). Updating the IDE to point to the source
one is quite simple.

As you can tell, I am not a big fan of maven. But, I am willing to go the
extra mile to support it, but just that mile :). I am working most of today
at getting things up into the OSS sonatype thingy, time that I am waisting
in not developing elasticsearch. This is what I almost always found with
maven, the time you spend on it just does not justifies it.

Shay

On Fri, Apr 2, 2010 at 8:49 PM, Paolo Castagna <
castagna.lists@googlemail.com> wrote:

Shay Banon wrote:

Don't think I am going to do that for maven... . The jar file itself will
also hold the code, source (and javadoc).

This will probably cause problems to people wanting to use plugins
such as:

And everybody else who rely on the "conventions" in place:

"If you browse the Maven central repository, you will notice
that the classifiers sources and javadoc are used to deploy
the project source code and API docs along with the packaged
class files."
-- http://maven.apache.org/pom.html#POM_Relationships

Paolo


(system) #7