Using spring-elasticsearch to configure es vs custom spring factory beans


(mfriedma) #1

Hi,

I'm evaluating using https://github.com/dadoonet/spring-elasticsearch

  • it looks quite good.

Earlier I had created a custom spring factory bean to configure a very
simple es transport client. I did not set a cluster name nor a node name at
the (single) es server. And with these defaults my default transport client
created by the factory bean works fine.

it seems that if one defines the cluster name and node name at the server
then the transport client needs this information too or it won't connect.
Or perhaps it just needs to know the cluster name. I haven't quite worked
that out.

In any case, I think I'd prefer to use spring-elasticsearch (xml context)
to configure everything instead of my custom factory.

The question: is spring-es reasonably mature? Are folks using it with
success? Or are there issues still being ironed out?

Many thanks,
Matt

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(David Pilato) #2

I know it's used in production (french customs for exemple ) and I met someone tonight in Amsterdam who is going in production in the next months.

I'd love to have more feedback !

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 00:04, mfriedma@afilias.info a écrit :

Hi,

I'm evaluating using https://github.com/dadoonet/spring-elasticsearch

  • it looks quite good.

Earlier I had created a custom spring factory bean to configure a very simple es transport client. I did not set a cluster name nor a node name at the (single) es server. And with these defaults my default transport client created by the factory bean works fine.

it seems that if one defines the cluster name and node name at the server then the transport client needs this information too or it won't connect. Or perhaps it just needs to know the cluster name. I haven't quite worked that out.

In any case, I think I'd prefer to use spring-elasticsearch (xml context) to configure everything instead of my custom factory.

The question: is spring-es reasonably mature? Are folks using it with success? Or are there issues still being ironed out?

Many thanks,
Matt

You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(mfriedma) #3

I did try it out a bit and I wasn't sure if I could use references to other
beans or existing properties (via ${property.name}) and so on in the fields
for node definitions for instance.

But I could end up using the utils ns as you suggest in the docs.
I definitely need to use property files (residing outside of the war/jar)
for the settings.

I wonder if it is more flexible to use the @Bean format with your Factory
classes rather than the namespace. Is the xml just as flexible as the java
config? Do you know how french customs uses it (xml or javaconfig)?

Thanks kindly for the contribution. Please elaborate.

Cheers, Matt

On Thursday, October 10, 2013 6:47:56 PM UTC-4, David Pilato wrote:

I know it's used in production (french customs for exemple ) and I met
someone tonight in Amsterdam who is going in production in the next months.

I'd love to have more feedback !

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 00:04, mfri...@afilias.info <javascript:> a écrit :

Hi,

I'm evaluating using https://github.com/dadoonet/spring-elasticsearch

  • it looks quite good.

Earlier I had created a custom spring factory bean to configure a very
simple es transport client. I did not set a cluster name nor a node name at
the (single) es server. And with these defaults my default transport client
created by the factory bean works fine.

it seems that if one defines the cluster name and node name at the server
then the transport client needs this information too or it won't connect.
Or perhaps it just needs to know the cluster name. I haven't quite worked
that out.

In any case, I think I'd prefer to use spring-elasticsearch (xml context)
to configure everything instead of my custom factory.

The question: is spring-es reasonably mature? Are folks using it with
success? Or are there issues still being ironed out?

Many thanks,
Matt

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearc...@googlegroups.com <javascript:>.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(David Pilato) #4

They were using XML then moved to javaconfig as far as I remember.

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 00:53, mfriedma@afilias.info a écrit :

I did try it out a bit and I wasn't sure if I could use references to other beans or existing properties (via ${property.name}) and so on in the fields for node definitions for instance.

But I could end up using the utils ns as you suggest in the docs. I definitely need to use property files (residing outside of the war/jar) for the settings.

I wonder if it is more flexible to use the @Bean format with your Factory classes rather than the namespace. Is the xml just as flexible as the java config? Do you know how french customs uses it (xml or javaconfig)?

Thanks kindly for the contribution. Please elaborate.

Cheers, Matt

On Thursday, October 10, 2013 6:47:56 PM UTC-4, David Pilato wrote:

I know it's used in production (french customs for exemple ) and I met someone tonight in Amsterdam who is going in production in the next months.

I'd love to have more feedback !

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 00:04, mfri...@afilias.info a écrit :

Hi,

I'm evaluating using https://github.com/dadoonet/spring-elasticsearch

  • it looks quite good.

Earlier I had created a custom spring factory bean to configure a very simple es transport client. I did not set a cluster name nor a node name at the (single) es server. And with these defaults my default transport client created by the factory bean works fine.

it seems that if one defines the cluster name and node name at the server then the transport client needs this information too or it won't connect. Or perhaps it just needs to know the cluster name. I haven't quite worked that out.

In any case, I think I'd prefer to use spring-elasticsearch (xml context) to configure everything instead of my custom factory.

The question: is spring-es reasonably mature? Are folks using it with success? Or are there issues still being ironed out?

Many thanks,
Matt

You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearc...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(mfriedma) #5

Do you have java config examples? I think such examples would improve the
library if they aren't already available. Cheers, Matt

On Friday, October 11, 2013 1:17:57 AM UTC-4, David Pilato wrote:

They were using XML then moved to javaconfig as far as I remember.

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 00:53, mfri...@afilias.info <javascript:> a écrit :

I did try it out a bit and I wasn't sure if I could use references to
other beans or existing properties (via ${property.name}) and so on in
the fields for node definitions for instance.

But I could end up using the utils ns as you suggest in the docs.
I definitely need to use property files (residing outside of the war/jar)
for the settings.

I wonder if it is more flexible to use the @Bean format with your Factory
classes rather than the namespace. Is the xml just as flexible as the java
config? Do you know how french customs uses it (xml or javaconfig)?

Thanks kindly for the contribution. Please elaborate.

Cheers, Matt

On Thursday, October 10, 2013 6:47:56 PM UTC-4, David Pilato wrote:

I know it's used in production (french customs for exemple ) and I met
someone tonight in Amsterdam who is going in production in the next months.

I'd love to have more feedback !

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 00:04, mfri...@afilias.info a écrit :

Hi,

I'm evaluating using https://github.com/dadoonet/spring-elasticsearch

  • it looks quite good.

Earlier I had created a custom spring factory bean to configure a very
simple es transport client. I did not set a cluster name nor a node name at
the (single) es server. And with these defaults my default transport client
created by the factory bean works fine.

it seems that if one defines the cluster name and node name at the server
then the transport client needs this information too or it won't connect.
Or perhaps it just needs to know the cluster name. I haven't quite worked
that out.

In any case, I think I'd prefer to use spring-elasticsearch (xml context)
to configure everything instead of my custom factory.

The question: is spring-es reasonably mature? Are folks using it with
success? Or are there issues still being ironed out?

Many thanks,
Matt

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearc...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearc...@googlegroups.com <javascript:>.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(David Pilato) #6

Did you look at src/test?
I think you could find some examples there.

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 16:55, mfriedma@afilias.info a écrit :

<mime-attachment.html>

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(mfriedma) #7

It would be better IMO to use
http://download.java.net/jdk7/archive/b123/docs/api/java/net/InetSocketAddress.html[]
instead
of a string[] to specify the nodes for the transport client.

Or even better supplement the api by overloading

public void setEsNodes(String[] esNodes)

with

public void setEsNodes(InetSocketAddress[] esNodes)

thanks,
Matt

On Fri, Oct 11, 2013 at 11:19 AM, David Pilato david@pilato.fr wrote:

Did you look at src/test?
I think you could find some examples there.

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 16:55, mfriedma@afilias.info a écrit :

<mime-attachment.html>

--
You received this message because you are subscribed to a topic in the
Google Groups "elasticsearch" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/elasticsearch/qAGfjzgENKw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(David Pilato) #8

Agree. Do you wanna send a pull request?

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 19:15, Matt Friedman mfriedma@afilias.info a écrit :

It would be better IMO to use http://download.java.net/jdk7/archive/b123/docs/api/java/net/InetSocketAddress.html[] instead of a string[] to specify the nodes for the transport client.

Or even better supplement the api by overloading

public void setEsNodes(String[] esNodes)

with

public void setEsNodes(InetSocketAddress[] esNodes)

thanks,
Matt

On Fri, Oct 11, 2013 at 11:19 AM, David Pilato david@pilato.fr wrote:

Did you look at src/test?
I think you could find some examples there.

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 16:55, mfriedma@afilias.info a écrit :

<mime-attachment.html>

--
You received this message because you are subscribed to a topic in the Google Groups "elasticsearch" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/elasticsearch/qAGfjzgENKw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(mfriedma) #9

Hi David,

Thanks for the opportunity to contribute. I hope my feedback via just
suggestions is ok for now. I would like to be able to work on the codebase
but atm I won't have the cycles. If I do get the chance I
will definitely send you a pull request. Will continue to work with your
library in our next sprint.

Many thanks,
Matt

On Friday, October 11, 2013 1:23:25 PM UTC-4, David Pilato wrote:

Agree. Do you wanna send a pull request?

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 19:15, Matt Friedman <mfri...@afilias.info <javascript:>>
a écrit :

It would be better IMO to use
http://download.java.net/jdk7/archive/b123/docs/api/java/net/InetSocketAddress.html[] instead
of a string[] to specify the nodes for the transport client.

Or even better supplement the api by overloading

public void setEsNodes(String[] esNodes)

with

public void setEsNodes(InetSocketAddress[] esNodes)

thanks,
Matt

On Fri, Oct 11, 2013 at 11:19 AM, David Pilato <da...@pilato.fr<javascript:>

wrote:

Did you look at src/test?
I think you could find some examples there.

--
David :wink:
Twitter : @dadoonet / @elasticsearchfr / @scrutmydocs

Le 11 oct. 2013 à 16:55, mfri...@afilias.info <javascript:> a écrit :

<mime-attachment.html>

--
You received this message because you are subscribed to a topic in the
Google Groups "elasticsearch" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/elasticsearch/qAGfjzgENKw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
elasticsearc...@googlegroups.com <javascript:>.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups
"elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to elasticsearc...@googlegroups.com <javascript:>.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "elasticsearch" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elasticsearch+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


(system) #10