zeynepyz
February 28, 2024, 3:11pm
1
Hello i was trying to contribute metricbeat modules because of my school project. I made some things now i can see metrics through kibana and in logs on my local. But there is something that i can't done and that is integration test. My unit test is working fine it has %90 coverage. But i got stuck on integration test. What should i do now? Should i raise pr and get help about it or share my codes on here and trying to fix the error?
zeynepyz
February 29, 2024, 9:41am
2
hello can you help me? @kcreddy
kcreddy
March 4, 2024, 9:59am
3
Hey @zeynepyz yes, please create PR and appropriate team should be assigned and you can discuss the failing tests there.
zeynepyz
March 4, 2024, 7:33pm
4
elastic:main ← zeynepyz:deneme
opened 07:05PM - 04 Mar 24 UTC
<!-- Type of change
Please label this PR with one of the following labels, depe… nding on the scope of your change:
- Bug
- Enhancement
- Breaking change
- Deprecation
- Cleanup
- Docs
-->
## Proposed commit message
I created new metricbeat module named k6. It takes k6 metrics via Rest API and indexes them then send them to elasticsearch. While doing this project, I schematized the metrics using mapstr. I am trying to improve myself and i want my github to fill with good projects that's why i did this.
<!-- Mandatory
Please explain:
- WHAT: patterns used, algorithms implemented, design architecture, message processing, etc.
- WHY: the rationale/motivation for the changes
This text will be pasted into the squash dialog when the change is committed and will be
a long term historical record of the change to help future contributors understand the
change, please help them by making it clear and comprehensive, they may be you.
If the commit title is adequate to describe both of these things, The text here may be omitted
or replaced with "See title". The title of the PR will be used as the commit message title when
the merge is made and the "See title" marker will be removed if present.
The text here and the PR title will be subject to the PR review process.
-->
## Checklist
<!-- Mandatory
Add a checklist of things that are required to be reviewed in order to have the PR approved
List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes. ~~Scratch this.~~)
-->
- [x] My code follows the style guidelines of this project
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added an entry in `CHANGELOG.next.asciidoc` or `CHANGELOG-developer.next.asciidoc`.
## Screenshots
<!-- Optional
Add here screenshots about how the project will be changed after the PR is applied. They could be related to web pages, terminal, etc, or any other image you consider important to be shared with the team.
-->
This is the expected error when k6 is not running.
## Logs
<!-- Recommended
Paste here output logs discovered while creating this PR, such as stack traces or integration logs, or any other output you consider important to be shared with the team.
-->
This will show that the k6 module is working. You will receive metrics too.
{"log.level":"warn","@timestamp":"2024-03-04T22:01:07.399+0300","log.logger":"cfgwarn","log.origin":{"function":"github.com/elastic/beats/v7/metricbeat/module/k6/k6metricset.New","file.name":"k6metricset/k6metricset.go","file.line":65},"message":"BETA: The k6 k6metricset metricset is beta.","service.name":"metricbeat","ecs.version":"1.6.0"}
Here is my pr. I wanna share this too.
system
April 1, 2024, 9:34pm
5
This topic was automatically closed 28 days after the last reply. New replies are no longer allowed.