Cannot upgrade 6.1.0 to 6.1.2

sdauletau · January 18, 2018, 10:46pm

We have elasticsearch 6.1.0 with custom default similarity.

Trying to upgrade from 6.1.0 to 6.1.2 and getting error when starting elasticsearch.

Caused by: java.lang.IllegalArgumentException: Unknown Similarity type [CustomSimilarityProvider] for [default]
	at org.elasticsearch.index.similarity.SimilarityService.<init>(SimilarityService.java:88) ~[elasticsearch-6.1.2.jar:6.1.2]
	at org.elasticsearch.cluster.metadata.MetaDataIndexUpgradeService.checkMappingsCompatibility(MetaDataIndexUpgradeService.java:139) ~[elasticsearch-6.1.2.jar:6.1.2]
	at org.elasticsearch.cluster.metadata.MetaDataIndexUpgradeService.upgradeIndexMetaData(MetaDataIndexUpgradeService.java:94) ~[elasticsearch-6.1.2.jar:6.1.2]

It looks, like the exception is from this code.

github.com

elastic/elasticsearch/blob/v6.1.2/core/src/main/java/org/elasticsearch/index/similarity/SimilarityService.java#L87


for (Map.Entry<String, Settings> entry : similaritySettings.entrySet()) {
    String name = entry.getKey();
    // Starting with v5.0 indices, it should no longer be possible to redefine built-in similarities
    if(BUILT_IN.containsKey(name) && indexSettings.getIndexVersionCreated().onOrAfter(Version.V_5_0_0_alpha1)) {
        throw new IllegalArgumentException("Cannot redefine built-in Similarity [" + name + "]");
    }
    Settings providerSettings = entry.getValue();
    String typeName = providerSettings.get("type");
    if (typeName == null) {
        throw new IllegalArgumentException("Similarity [" + name + "] must have an associated type");
    } else if ((similarities.containsKey(typeName) || BUILT_IN.containsKey(typeName)) == false) {
        throw new IllegalArgumentException("Unknown Similarity type [" + typeName + "] for [" + name + "]");
    }
    SimilarityProvider.Factory defaultFactory = BUILT_IN.get(typeName);
    SimilarityProvider.Factory factory = similarities.getOrDefault(typeName, defaultFactory);
    providers.put(name, factory.create(name, providerSettings, indexSettings.getSettings(), scriptService));
}
Map<String, SimilarityProvider> providerMapping = addSimilarities(similaritySettings, indexSettings.getSettings(), scriptService,
        DEFAULTS);
for (Map.Entry<String, SimilarityProvider> entry : providerMapping.entrySet()) {
    // Avoid overwriting custom providers for indices older that v5.0

Should the check be

if ((similarities.containsKey(typeName) == false || BUILT_IN.containsKey(typeName)) == false)

Ivan · January 19, 2018, 5:06am

I think this might be fixed in 6.2:

system · February 16, 2018, 5:06am

This topic was automatically closed 28 days after the last reply. New replies are no longer allowed.