New community beat Perfmonbeat


(Maddin2016) #1

Hi @all,

i would like to show you a new community beat i created. It's called Perfmonbeat and it is a beat to collect perfomance counters from windows. It's yet very basic and there is a lot more to do ( exception handling, configs, naming of outputs, ...). But i want to discuss with you if it goes in the right direction and if there is a need for such a beat.

See here

BG

Martin


(Andrew Kroh) #2

I definitely like the idea of collecting perf data through the PDH API.

It looks like this would work nicely as a MetricSet in Metricbeat. Instead of using the beat generator there is a metricset generator that creates a standalone beat using Metricbeat as a framework. Then you would have a MetricSet that could be later integrated into Metricbeat or be used as a plugin.

I didn't review the code since it's a work in progress. But one thing you should consider doing is generating code for the methods you need in the PDH API (here's a place where we do that in gosigar). It uses the mksyscall_windows tool from Go.

And if you require constants from header files you can do some generation there too. You would create a defs_windows.go file that contains cgo code then run a generator to build another go file. See defs_windows.go.

This makes the code a little cleaner and means that you don't need to use cgo for your builds which then allows for easier cross-compiles.


(Maddin2016) #3

Hi @andrewkroh, many thanks for that detailed answer!! Especially for that part with cgo!! Really exciting stuff :open_mouth: I also think it is better to create this as a MetricSet. I just wanted to start with coding. I create a new metricset an come back if i'm done.


(Maddin2016) #4

Hi @andrewkroh, i have create a new repo to build a MetricSet instead of a beat. Now i'm try to configure config settings for that metricset. Assume the following structure i created

-module
    -windows
        -_meta
        - perfmon
            -_meta
                data.json
                fields.yaml
            perfmon.go

windows is my module and perfmon my metricset. Where i can add config only for that metricset
e.g.

- module: windows
  metricsets: ["perfmon"]
  enabled: true
  period: 1s
  hosts: ["localhost"]
  perfmon.counters:  
    - alias: "Prozessorzeit"
      query: "\\Prozessorinformationen(*)\\Prozessorzeit (%)"

(Maddin2016) #5

I have found it in the documentation


(Maddin2016) #6

Hi @andrewkroh, i have created file defs_windows.go with the following content

package perfmon

/*
#include <windows.h>
#include <stdio.h>
#include <conio.h>
#include <pdh.h>
#include <pdhmsg.h>
#cgo LDFLAGS: -lpdh
*/
import "C"

const (
	ERROR_SUCESS            = C.ERROR_SUCCESS
	PDH_STATUS_VALID_DATA   = C.PDH_CSTATUS_VALID_DATA
	PDH_STATUS_NEW_DATA     = C.PDH_CSTATUS_NEW_DATA
	PDH_NO_DATA             = C.PDH_NO_DATA
	PDH_STATUS_NO_OBJECT    = C.PDH_CSTATUS_NO_OBJECT
	PDH_STATUS_NO_COUNTER   = C.PDH_CSTATUS_NO_COUNTER
	PDH_STATUS_INVALID_DATA = C.PDH_CSTATUS_INVALID_DATA
	PDH_INVALID_HANDLE      = C.PDH_INVALID_HANDLE
	PDH_INVALID_DATA        = C.PDH_INVALID_DATA
	PDH_NO_MORE_DATA        = C.PDH_NO_MORE_DATA
	PdhFmtDouble            = C.PDH_FMT_DOUBLE
	PdhFmtLarge             = C.PDH_FMT_LARGE
	PdhFmtLong              = C.PDH_FMT_LONG
)

type PdhCounterValue C.PDH_FMT_COUNTERVALUE

i then call go tool cgo -godefs defs_windows.go > defs_windows_amd64.go which creates this output

// Created by cgo -godefs - DO NOT EDIT
// cgo.exe -godefs defs_windows.go

package perfmon

const (
	ERROR_SUCESS		= 0x0
	PDH_STATUS_VALID_DATA	= 0x0
	PDH_STATUS_NEW_DATA	= 0x1
	PDH_NO_DATA		= 0x800007d5
	PDH_STATUS_NO_OBJECT	= 0xc0000bb8
	PDH_STATUS_NO_COUNTER	= 0xc0000bb9
	PDH_STATUS_INVALID_DATA	= 0xc0000bba
	PDH_INVALID_HANDLE	= 0xc0000bbc
	PDH_INVALID_DATA	= 0xc0000bc6
	PDH_NO_MORE_DATA	= 0xc0000bcc
	PdhFmtDouble		= 0x200
	PdhFmtLarge		= 0x400
	PdhFmtLong		= 0x100
)

type PdhCounterValue struct {
	CStatus		uint32
	Pad_cgo_0	[4]byte
	LongValue	int32
	Pad_cgo_1	[4]byte
}

But if i then call go build or go generate i get this error \perfmon\defs_windows_amd64.go: unexpected NUL in input. Any ideas??


(Andrew Kroh) #7

Do you have a // +build ignore at the top of the defs_windows.go file?


(Maddin2016) #8

Should that command be present in all def files? defs_windows_amd64.go, defs_windows_386.go. Is it necessary to create these 386, amd64 files or is it better to copy the output from the cgo command into defs_windows.go and just have this file? There is also one thing more :see_no_evil: i created a wrapper pdh_windows.go like you say.

//go:generate go run $GOROOT/src/syscall/mksyscall_windows.go -output pdh_windows.go pdh.go
// Windows API calls
//sys   _PdhOpenQuery(dataSource *string, userData int, query *syscall.Handle) (err int) = pdh.PdhOpenQuery
//sys   _PdhAddCounter(query syscall.Handle, counterPath string, userData int, counter *syscall.Handle) (err int) = pdh.PdhAddCounter
//sys   _PdhCollectQueryData(query syscall.Handle) (err int) = pdh.PdhCollectQueryData
//sys   _PdhGetFormattedCounterValue(counter syscall.Handle, format int, counterType int, value PdhCounterValue) (err int) = pdh.GetFormattedCounterValue

This all works fine, except in the output file there is an import statement "golang.org/x/sys/windows". which is used by modpdh = windows.NewLazySystemDLL("pdh.dll"). should i use syscall instead and then modpdh = syscall.NewLazyDLL("pdh.dll")??

Sorry for all that questions :disappointed_relieved:


(Andrew Kroh) #9

defs_windows.go is the source file for generating defs_windows_amd64.go and defs_windows_386.go. All three files should be committed to your repo. defs_windows.go will not be used by go build so it needs to have the build tag so that the compiler ignore it. Doing this allows us to build without needing cgo. cgo is only needed if we have to change defs_windows.go and need to regenerate defs_windows_amd64.go and defs_windows_386.go.

What "output" file? The code generated by mksyscall_windows.go should have imports for syscall and not windows.


(Maddin2016) #10

pdh_windows.go. This is the generated file from mksyscall_windows.go. There is an import for windows. Maybe a bug or and old version??


(Andrew Kroh) #11

It looks like it does have logic for the golang.org/x/sys/windows package. https://golang.org/src/syscall/mksyscall_windows.go#L741 I didn't examine the logic, but I would prefer functions in the syscall package over golang.org/x/sys/windows if you have a choice (just to reduce the external deps). But if there's a function in the windows package that makes life easier use it.


(Maddin2016) #12

Ok, i will use the syscall package. Here are the new metricset i have created (ignore the name of the beat). There is only that error with unexpteced NUL in defs_windows_amd64.go. Maybe you have some time to look over. I can't see whats wrong with this file :confused:


(Andrew Kroh) #13

Where's the error coming from?

It builds for me:

$ pwd
/Users/akroh/go/src/github.com/maddin2016/pdhbeat/module/windows
$ GOOS=windows GOARCH=amd64 go build; echo $?
0

(Maddin2016) #14

That error comes if i'm trying to build on windows.


(Maddin2016) #15

Ohh, got it. This error throws if you are in the wrong folder. I tried go build in maddin2016/pdhbeat instead of maddin2016\pdhbeat\module\windows. How can i test if the new metricset is working? Do i have to build the whole metricbeat?


(Andrew Kroh) #16

go build in github.com/maddin2016/pdhbeat will produce pdhbeat.exe that you can use. If you uncomment this line you can use the the normal metricbeat modules too (the configuration will all be namespaced under pdhbeat instead of metricbeat).

Check defs_windows.go for bad characters. Run gofmt on it and gofmt on the output files too. I'm seeing bad encoding.

defs_windows_amd64.go:1:1: illegal UTF-8 encoding
defs_windows_amd64.go:1:1: illegal character U+FFFD '�'
defs_windows_amd64.go:1:2: illegal UTF-8 encoding

(Maddin2016) #17

It seems that the go tool cgo command add these characters. I had to explicit save the file as UTF-8 with notepad.


(Maddin2016) #18

Hi @andrewkroh, if you had the time can try to run this metricbeat on a windows machine. I had to do some fixing of types and add some errors. But basically it is running.


(Steffen Siering) #19

@maddin2016 with go make sure your files are UTF-8 always. By default windows tools often use UTF16LE which might not parse well with utf-8.


(Maddin2016) #20

Yeap, comming from .NET UTF16 is the default if you not specify encoding.