But it sounds like I made a big mistake going with App Search
I don't see it that way. There are tradeoffs between App Search and Workplace Search, and neither would perfectly cover 100% of what you're trying to do. Sounds like App Search was the right choice for all the sites that are working well with the App Search Crawler, and now we just need to figure out how to get your Confluence search results displayed alongside the crawl results.
I'll try to answer individual questions below.
Does WS also do web crawling?
When you say "search over 2 products from single interface", does that mean I'd be able to show results blended from the workplace search connectors and also our existing app search engines?
Yes. Our Search UI product is a front-end framework for helping you build search experiences. App Search can generate a Search UI experience for you, but you can modify the generated experience, or build your own from scratch. Search UI can work with App Search, Workplace Search, and/or Elasticsearch.
Confluence Cloud connector package that can be used outside of WS - do you have a feel for when this could be ready?
I do not. I can encourage you to watch our release notes, as it is a connector we know many of our customers care about. But we cannot make promises for when new features will be delivered, as we are a publicly traded company. However, if you have a support relationship with Elastic, I'd encourage you to file an Enhancement Request, to help us understand your use case and timeline, and that may help influence timings.
if I did try to implement confluence connector into app search, is it some of the same work that you are doing in 2? Is it a big job or something people do all the time?
It's very doable. In fact, in a free week, I built a logstash input plugin that could extract data from Confluence Cloud. You'd be welcome to fork this if you'd like. Do note - this repo is not an Elastic product, but my personal code, so it does not come with any support guarantees. But even if you don't use it directly, it should give you an idea of how you could take the
connectors_sdk gem and use it as a library to get data out of Confluence.
Is "Site Search" still a part of Enterprise search going forward, and how would that fit in?
"Site Search" is going to live on swiftype.com for the foreseeable future. We're working to ensure that the Crawler is as full-serviced in Enterprise Search as it is in swiftype.com, but we do see them as separate use cases, and have not planned to migrate customers at this time.