matw
April 28, 2021, 9:29am
3
Hi
## Summary
Resolves https://github.com/elastic/kibana/issues/64444
Resolves https://github.com/elastic/kibana/issues/2516
Resolves https://github.com/elastic/kibana/issues/2128
**This converts the `Data table` visualization into `React` + EUI `DataGrid` component.**
By default a new version of visualization will be used. Discussed with @timroes .
To turn on the legacy one, include `vis_type_table.legacyVisEnabled: true` setting in `kibana.yml`.
**Single table mode:**
**Split table mode (several grids displayed):**
The split table mode could have performance issue while a lot of data grids render at once.
Despite this, the PR is good to go, since:
1. the feature is not widely used;
2. the legacy vis also has the inherent performance issue;
A separate issue is created to track and potentially solve the problem: https://github.com/elastic/kibana/issues/84509
---
### Changes include:
- either the legacy or the new visualization implementation is lazy loaded once [depending on the feature flag](https://github.com/elastic/kibana/pull/70801/files#diff-79003809e2d3517001d3be825d7d01f7cad641024117a5915cb1557ce9b2a4ebR61) `legacyVisEnabled`;
- legacy functional tests were adapted to check the new grid implementation, [few of them](https://github.com/elastic/kibana/pull/70801/files#diff-d672646828c4ca3e4e6f345e5ccce50cc040ff7ed4b8a334d1108a2b1264ac38) were saved to check the legacy data table in a separate [thread](https://github.com/elastic/kibana/pull/70801/files#diff-4e407c67fa238b7f6590efe3b7af0786cc0cafde9a679e26cae1c96f2284599d) ([was discussed here](https://github.com/elastic/kibana/pull/70801/files#r512640540))
---
### Release notes:
- `Show toolbar` option adds an ability to `show/hide` the visualization toolbar, where the only `Export` button currently live (the toolbar will be expanded in future releases).
By default, a new visualization will have the toolbar disabled. Saved objects will be migrated to have the toolbar enabled initially.
( [feature commit](https://github.com/elastic/kibana/pull/70801/commits/0a90debc877405468293c18f6705c5483b3bec51), [migration script commit](https://github.com/elastic/kibana/pull/70801/commits/aac4c2df092e6059874646a5022e1322eca661a9) )
- Exported as CSV tables will preserve the sorting by column direction!
- Customizing a column `width` option is in. The value is saved into the `uiState` - that means columns width will be saved even after page reload. While using `Split table` mode, columns width will be synchronized between tables.
**Single table mode**
**Split table mode**
- Expand a cell to see a collapsed content - hover over the cell to see the expand button:
### Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [x] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [x] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
elastic:master ← sulemanof:EUIfication/data_table
opened 01:44PM - 06 Jul 20 UTC
By setting vis_type_table.legacyVisEnabled: true setting in kibana.yml you can still use the old one.
Best,